Closed
Bug 1315257
Opened 8 years ago
Closed 8 years ago
Update L10N Screenshot Tests
Categories
(Firefox for iOS :: Build & Test, defect)
Tracking
()
RESOLVED
FIXED
Iteration:
1.8
People
(Reporter: st3fan, Assigned: st3fan)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
The tests do not compile and run anymore. Make sure they are up to date with the latest xcode/swift/ios. Also fix issues related to UI changes.
|
Assignee | |
Comment 1•8 years ago
|
||
This patch brings the L10N Screenshots back. See more details in the PR.
I would like to land this on master but also uplift it to v6.x so that we can make screenshots of the product that we ship. The only changes in non-test code is the addition of accessibility identifiers. I think that is pretty low risk but let me know if you think otherwise.
Attachment #8807945 -
Flags: review?(sleroux)
Attachment #8807945 -
Flags: feedback?(npark)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8807945 [details] [review]
PR: https://github.com/mozilla-mobile/firefox-ios/pull/2221
Looks good! Land away
Attachment #8807945 -
Flags: review?(sleroux) → review+
|
||
Comment 3•8 years ago
|
||
thanks for letting me know about this, looks fine to me.
|
|
||
Updated•8 years ago
|
Attachment #8807945 -
Flags: feedback?(npark) → feedback+
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [needsuplift]
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•8 years ago
|
||
v6.x 8d7aebd
Iteration: --- → 1.8
status-fxios-v6.0:
--- → fixed
status-fxios-v7.0:
--- → fixed
tracking-fxios:
--- → 6.0+
Whiteboard: [needsuplift] → [MobileAS]
You need to log in
before you can comment on or make changes to this bug.
Description
•