1315262 - Intermittent test_suspend.html,test_fetch_basic_http.html,test_fileBlobSubWorker.xul,test_child-src_worker_data.html,test_file.xul,test_chromeWorkerJSM.xul,test_child-src_worker.html | application crashed [@ js::ShapeTable::searchUnchecked<0>(jsid)]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Treeherder Bug Filer]

Filed by: tomcat [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=38653365&repo=mozilla-inbound

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-win32-pgo/1478255402/mozilla-inbound_win7_vm_test_pgo-mochitest-4-bm138-tests1-windows-build51.txt.gz

Comment 2

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 4
* mozilla-central: 2
* mozilla-inbound: 1

Platform breakdown:
* linux32: 4
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1315262&startday=2016-11-07&endday=2016-11-13&tree=all

Comment 3

[Jan de Mooij [:jandem]]

Probably mine.

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Patch

We shouldn't purge ShapeTables in the self-hosting zone, as that zone is shared with worker threads.

Comment 5

[Jan de Mooij [:jandem]]

[Tracking Requested - why for this release]:
Crashes.

Comment 6

[Jon Coppeard (:jonco) (PTO until 3rd April)]

Comment on attachment 8810804 [details] [diff] [review]
Patch

Review of attachment 8810804 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsfun.cpp
@@ +1595,5 @@
>      if (comp->hasBeenEntered() && !rt->allowRelazificationForTesting)
>          return;
>  
>      // Don't relazify if the compartment is being debugged or is the
>      // self-hosting compartment.

We should probably update this comment to match.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d6553075ae1
Don't purge shape tables in the self-hosting zone. r=jonco

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8d6553075ae1

Comment 9

[Jan de Mooij [:jandem]]

Comment on attachment 8810804 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: Bug 1314569.
[User impact if declined]: Crashes.
[Describe test coverage new/current, TreeHerder]: Seems to fix oranges so far.
[Risks and why]: Low risk, just adds an extra check.
[String/UUID change made/needed]: None.

Comment 10

[Marcia Knous [:marcia]]

Tracking 53- since this is resolved fixed.

Comment 11

[Intermittent Failures Robot]

5 failures in 715 pushes (0.007 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 3
* mozilla-central: 2

Platform breakdown:
* linux64: 4
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1315262&startday=2016-11-14&endday=2016-11-20&tree=all

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8810804 [details] [diff] [review]
Patch

fix crashes including oranges on treeherder, take in aurora52

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bffc76d5c3e0