add devtools/CODE_OF_CONDUCT.md

RESOLVED FIXED in Firefox 53

Status

defect
P2
normal
RESOLVED FIXED
3 years ago
10 months ago

People

(Reporter: tromey, Assigned: tromey)

Tracking

unspecified
Firefox 53

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
We recently discussed adding a devtools/CODE_OF_CONDUCT.md to the tree
to explain our code of conduct.  It will be landed via this bug.
Priority: -- → P2
(Assignee)

Comment 1

3 years ago
Specifically we discussed lifting from the Rust CoC: https://www.rust-lang.org/en-US/conduct.html
We were also asked to consider linking to the Moz guidelines: https://www.mozilla.org/en-US/about/governance/policies/participation/
... with the note that we could have something more restrictive if we wanted.
Also the Rust CoC links to an earlier version the contributor covenant, main site here:
http://contributor-covenant.org/

I plan to base the first draft on the Rust CoC; what I like about it is that it is clear, specific,
and has an enforcement policy.
(Assignee)

Comment 2

3 years ago
I chose to remove this text:

> Please keep unstructured critique to a minimum. If you have solid
> ideas you want to experiment with, make a fork and see how it works.

... on the basis that it didn't seem all that relevant to devtools.


Rust has a moderation team; I'm not completely certain who to put down for contact
for devtools.  Maybe we can get an email alias.  Meanwhile I've listed the
alias mentioned in the Moz community participation guidelines.
Comment hidden (mozreview-request)

Comment 4

3 years ago
mozreview-review
Comment on attachment 8808366 [details]
Bug 1315344 - add devtools/CODE_OF_CONDUCT.md;

https://reviewboard.mozilla.org/r/91182/#review91610

It seems like a reasonable starting point on first read.

::: devtools/CODE_OF_CONDUCT.md:1
(Diff revision 1)
> +# Devtools Code of Conduct

Nit: Please use "DevTools" or "Developer Tools" at least in this title to soothe my OCD.

The lowercase "devtools" in the rest of the document is also a bit strange, but I don't mind it as much as "Devtools".

::: devtools/CODE_OF_CONDUCT.md:56
(Diff revision 1)
> +Remarks that violate these standards of conduct, including hateful,
> +hurtful, oppressive, or exclusionary remarks, are not
> +allowed. (Cursing is allowed, but never targeting another user, and
> +never in a hateful manner.)
> +
> +Remarks that moderators find inappropriate, whether listed in the code

This document does not seem to define precisely who the moderators are.  Should there be a clear list somewhere that you can link to?  Is it meant to just be "channel ops" even in non-IRC contexts?
I guess you also mentioned the moderation definition issue here in the bug.  Looking at Rust, it seems they have an email alias and a page with names (plus pictures!) of those on the moderation team.  Perhaps something similar is appropriate?

Comment 7

3 years ago
mozreview-review
Comment on attachment 8808366 [details]
Bug 1315344 - add devtools/CODE_OF_CONDUCT.md;

https://reviewboard.mozilla.org/r/91182/#review92702

Fly-by review, with a couple of additional comments on top of what jryans already said.
I think this is really good. Thanks Tom.
My main point is that we should list our different channels of communications (github, bugzilla, irc, mailing list) and detail what moderation looks like on each of them.

::: devtools/CODE_OF_CONDUCT.md:1
(Diff revision 1)
> +# Devtools Code of Conduct

Agreed, DevTools is the correct casing we should use instead of devtools. But in cases of more "formal" documents like this one, I'd vote for the longer Developer Tools form.

::: devtools/CODE_OF_CONDUCT.md:48
(Diff revision 1)
> +conduct. If you feel that a thread needs moderation, please contact
> +the one of the channel ops or inclusion@mozilla.com.

s/contact the one of the channel ops/contact one of the channel ops

::: devtools/CODE_OF_CONDUCT.md:49
(Diff revision 1)
> +
> +# Moderation
> +
> +These are the policies for upholding our community’s standards of
> +conduct. If you feel that a thread needs moderation, please contact
> +the one of the channel ops or inclusion@mozilla.com.

linkify the email address:
[inclusion@mozilla.com](mailto:inclusion@mozilla.com)

::: devtools/CODE_OF_CONDUCT.md:56
(Diff revision 1)
> +Remarks that violate these standards of conduct, including hateful,
> +hurtful, oppressive, or exclusionary remarks, are not
> +allowed. (Cursing is allowed, but never targeting another user, and
> +never in a hateful manner.)
> +
> +Remarks that moderators find inappropriate, whether listed in the code

Agreed, we need a very clear way to identify who to contact depending on the context.
I would say:

- IRC: a channel ops
- bugzilla: inclusion@mozilla.com
- GitHub (the debugger.html repo): inclusion@mozilla.com, but also maybe link to https://github.com/devtools-html/debugger.html/blob/master/CODE_OF_CONDUCT.md
- the dev-developer-tools mailing list: inclusion@mozilla.com
Comment hidden (mozreview-request)

Comment 9

2 years ago
mozreview-review
Comment on attachment 8808366 [details]
Bug 1315344 - add devtools/CODE_OF_CONDUCT.md;

https://reviewboard.mozilla.org/r/91182/#review95116

Great, this looks good to me!  We can always refine details later as needed.

Thanks for working on it! :)

::: devtools/CODE_OF_CONDUCT.md:51
(Diff revisions 1 - 2)
>  
>  These are the policies for upholding our community’s standards of
> -conduct. If you feel that a thread needs moderation, please contact
> -the one of the channel ops or inclusion@mozilla.com.
> +conduct. If you feel that a thread needs moderation, please use the
> +point of contact for the medium in which you're communicating:
> +
> +* For one of the irc channels, contact a channel op;

Nit: IRC (caps)
Attachment #8808366 - Flags: review?(jryans) → review+

Comment 10

2 years ago
mozreview-review
Comment on attachment 8808366 [details]
Bug 1315344 - add devtools/CODE_OF_CONDUCT.md;

https://reviewboard.mozilla.org/r/91182/#review95182
Attachment #8808366 - Flags: review?(pbrosset) → review+
Thanks Tom for working on this. This looks great.
Once this lands, could you please send an email to dev-developer-tools with:
- a link to the code,
- a request for people to read it (and read the Mozilla participation guidelines and http://citizencodeofconduct.org/ too),
- a request for channel ops to understand the implications of their role (they should be comfortable with and know how to moderate).
Thanks.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 15

2 years ago
Switching review to Sole as discussed.
Helen, I realized just now that we did't discuss this with you - I welcome
your review if you're so inclined.

Comment 16

2 years ago
mozreview-review
Comment on attachment 8808366 [details]
Bug 1315344 - add devtools/CODE_OF_CONDUCT.md;

https://reviewboard.mozilla.org/r/91182/#review106688

::: devtools/CODE_OF_CONDUCT.md:5
(Diff revision 5)
> +# Developer Tools Code of Conduct
> +
> +This file describes the Developer Tools (aka "DevTools") code of conduct.
> +
> +The

I would move this line to the end of the document as a "these participation guidelines also apply" rather than a "worth reading" mention.

::: devtools/CODE_OF_CONDUCT.md:51
(Diff revision 5)
> +
> +These are the policies for upholding our community’s standards of
> +conduct. If you feel that a thread needs moderation, please use the
> +point of contact for the medium in which you're communicating:
> +
> +* For one of the IRC channels, contact a channel op;

replace 'op' with operator, perhaps add a note that explains that operators have an '@' in front of their nicknames (not everyone is familiar with IRC!)

::: devtools/CODE_OF_CONDUCT.md:54
(Diff revision 5)
> +point of contact for the medium in which you're communicating:
> +
> +* For one of the IRC channels, contact a channel op;
> +* For Bugzilla or the dev-developer-tools mailing list, contact
> +  [inclusion@mozilla.com](mailto:inclusion@mozilla.com);
> +* For the debugger.html repo on GitHub, also contact

I'd rephrase this as "this project has its own code of conduct available at XYZ, but you can also email inclusion@..."

Comment 17

2 years ago
mozreview-review
Comment on attachment 8808366 [details]
Bug 1315344 - add devtools/CODE_OF_CONDUCT.md;

https://reviewboard.mozilla.org/r/91182/#review106692

I guess it's a "r+" to mark this review as finished, but I would like my comments to be addressed before considering the bug closed.
Attachment #8808366 - Flags: review?(sole) → review+
Comment hidden (mozreview-request)

Comment 19

2 years ago
Pushed by ttromey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e393454e5286
add devtools/CODE_OF_CONDUCT.md; r=jryans,pbro,sole

Comment 20

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e393454e5286
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

10 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.