1315362 - Add a debug setting to enable bidirectional bookmark sync

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Richard Newman [:rnewman]]

Currently this is just turned off, and the only way to turn it on is to install a new build.

It would be super convenient for testing to provide an entry in the debug menu that we show when you tap-tap-tap on the version in Settings. This reduces the difficulty of testing, and will thus give us a way to mitigate risk around turning this feature on.

This doesn't need localized strings, because it's a debug menu. Steph and Stefan, your call whether you want to squeeze this in 6.0.

Comment 1

[Stephan Leroux [:sleroux]]

Are there any issues being able to enable then disable bidirectional bookmark syncing? I vaguely remember that once a user turns it on they can't go back.

Comment 2

[Richard Newman [:rnewman]]

Once you turn it on, turning it off will have undesirable results -- you won't see new, unmerged remote bookmark changes in the UI. That's the motivation for making this a debug setting, rather than a real setting: it's so engineers can opt-in to a process they understand.

Comment 3

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request:https://github.com/mozilla-mobile/firefox-ios/pull/2239

Comment 4

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/commit/7e068f87e30720b55ec520375c910675231d5385

Comment 5

[Stephan Leroux [:sleroux]]

v6.x 47b8cc1