1315370 - Portrait sometimes shows navigation buttons in URL bar

Status: RESOLVED FIXED

(Focus-iOS :: General, defect, P1)

Description

[Brian Nicholson (:bnicholson)]

Barbara reported an issue on her iPhone 7 where portrait was showing the back/forward/etc. buttons in the top URL bar (in addition to them being shown in the bottom toolbar). It sounds like the issue is intermittent, and I haven't been able to reproduce. Steps most welcome!

Comment 2

[Brian Nicholson (:bnicholson)]

No luck hitting this -- maybe this got fixed already. Unassigning myself until we get another report.

Comment 3

[Brian Nicholson (:bnicholson)]

Just hit this a few minutes ago. Trying to come up with STR, I've been able to hit it again on occasion, but the steps aren't very reliable (sometimes takes 30+ tries):

1) Go to google.com (hit "g" then Go).
2) Rotate to landscape orientation.
3) Press Erase.
4) Turn the screen off.
5) Rotate to portrait orientation.
6) Unlock the phone.
7) Repeat from step 1.

Comment 4

[Brian Nicholson (:bnicholson)]

I have a much higher success rate if I push the top right settings button between steps 3 and 4, then press Back between steps 6 and 7.

Comment 5

[Brian Nicholson (:bnicholson)]

Apparently UIDevice.current.orientation is unreliable. After step 5 in comment 3, UIDevice.current.orientation.isLandscape is *true* when viewWillTransition is fired (including in the completion block to coordinator.animate(alongsideTransition:)), so we never get signalled that the phone is rotated to portrait.

I noticed that the size given to viewWillTransition is at least correct, so as a workaround we can try comparing size.width to size.height.

Comment 6

[Brian Nicholson (:bnicholson)]

master: 488859557302ccf9aedacb36b45ea8faed5f3c91