Closed Bug 1315438 Opened 4 years ago Closed 4 years ago

Minor typo in the paths in 3rd party library list

Categories

(Firefox Build System :: Source Code Analysis, defect)

All
Other
defect
Not set
trivial

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: psnyde2, Assigned: psnyde2, Mentored)

References

()

Details

(Whiteboard: [specification][type:bug])

Attachments

(1 file)

What did you do?
================
Opened up tools/rewriting/ThirdPartyPaths.txt

What happened?
==============
I saw the path "media/kiss_ftt"

What should have happened?
==========================
This should be "media/kiss_fft"

Is there anything else we should know?
======================================
Severity: normal → trivial
Component: Code Cleanup → General
Product: Mozilla Developer Network → Firefox
Version: unspecified → Trunk
Summary: Minor typo in the paths in 3rd party library paths → Minor typo in the paths in 3rd party library list
Blocks: 1183143
Status: UNCONFIRMED → NEW
Component: General → Rewriting and Analysis
Ever confirmed: true
Product: Firefox → Core
This is trivial to fix, any volunteer? I can help with this.
Mentor: sledru
Sure, if someone didn't mind doing a bit of handholding, I'd like to give it a whirl as a first big to fix. Is a patch submitted here good, or a branch and a merge request?  I did a quick tour of mdn and didn't see guidelines for submitting patches
(In reply to psnyde2 from comment #2)
> Sure, if someone didn't mind doing a bit of handholding, I'd like to give it
> a whirl as a first big to fix. Is a patch submitted here good, or a branch
> and a merge request?  I did a quick tour of mdn and didn't see guidelines
> for submitting patches
The protocol is to upload patches here, ask for a review and after that mark the patch for checkin-needed. A list with reviewers for each module can be found here: https://wiki.mozilla.org/Modules/All
Attachment #8807925 - Attachment description: 1315438-correcting-third-party-paths.txt → Minor correction to the path for the third party media/kiss_fft path in the list of third party libraries in tools/rewriting/ThirdPartyPaths.txt
Attachment #8807925 - Attachment is patch: true
(In reply to Andi-Bogdan Postelnicu from comment #3)
> (In reply to psnyde2 from comment #2)
> > Sure, if someone didn't mind doing a bit of handholding, I'd like to give it
> > a whirl as a first big to fix. Is a patch submitted here good, or a branch
> > and a merge request?  I did a quick tour of mdn and didn't see guidelines
> > for submitting patches
> The protocol is to upload patches here, ask for a review and after that mark
> the patch for checkin-needed. A list with reviewers for each module can be
> found here: https://wiki.mozilla.org/Modules/All

Thank you for cluing me in on the procedure.  This is good to go for a review then.  I don't see any formal way of requesting a review, so I'm hoping doing so in this text is sufficient.
(In reply to psnyde2 from comment #5)
> (In reply to Andi-Bogdan Postelnicu from comment #3)
> > (In reply to psnyde2 from comment #2)
> > > Sure, if someone didn't mind doing a bit of handholding, I'd like to give it
> > > a whirl as a first big to fix. Is a patch submitted here good, or a branch
> > > and a merge request?  I did a quick tour of mdn and didn't see guidelines
> > > for submitting patches
> > The protocol is to upload patches here, ask for a review and after that mark
> > the patch for checkin-needed. A list with reviewers for each module can be
> > found here: https://wiki.mozilla.org/Modules/All
> 
> Thank you for cluing me in on the procedure.  This is good to go for a
> review then.  I don't see any formal way of requesting a review, so I'm
> hoping doing so in this text is sufficient.

We're almost there, bu there are some things that need to be changed:

1. Add a reviewer to the patch by going to the patch details and in the review section add peer and mark it as r?
2. Here at Mozilla we have the patch title standardised as:
            [Bugzilla ID] - [Patch Description]
   For this patch in particular a good title is:
            Bug 1315438 - fix path for media/kiss_fft

For start a Michael - michael@thelayzells.com is a good reviewer for this patch.
Attachment #8807925 - Attachment filename: 1315438-correcting-third-party-paths.txt → kiss_fft
Attachment #8807925 - Attachment filename: kiss_fft → Bug 1315438 - fix path for media_kiss_fft
Attachment #8807925 - Flags: review+
Attachment #8807925 - Flags: review+ → review?(michael)
Attachment #8807925 - Attachment description: Minor correction to the path for the third party media/kiss_fft path in the list of third party libraries in tools/rewriting/ThirdPartyPaths.txt → Bug 1315438 - fix path for media/kiss_fft
Comment on attachment 8807925 [details] [diff] [review]
Bug 1315438 - fix path for media/kiss_fft

Review of attachment 8807925 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks for the patch :)

When you're ready to check in the patch, add the keyword 'checkin-needed' under the tracking section to this bug, and a sheriff will come by and check it in for you.
Attachment #8807925 - Flags: review?(michael) → review+
Keywords: checkin-needed
Done, thanks much!
In the future, please make sure you've got Mercurial configured to generate patches with the proper commit information. The |./mach mercurial-setup| command automates the process, otherwise you can do so manually following the directions below:
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Thanks for the patch!
Assignee: nobody → psnyde2
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a19077a2bd28
Fix the path to kiss_fft in the third party library list. r=mystor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a19077a2bd28
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.