1315438 - Minor typo in the paths in 3rd party library list

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[psnyde2]

What did you do?
================
Opened up tools/rewriting/ThirdPartyPaths.txt

What happened?
==============
I saw the path "media/kiss_ftt"

What should have happened?
==========================
This should be "media/kiss_fft"

Is there anything else we should know?
======================================

Comment 1

[Sylvestre Ledru [:Sylvestre]]

This is trivial to fix, any volunteer? I can help with this.

Comment 2

[psnyde2]

Sure, if someone didn't mind doing a bit of handholding, I'd like to give it a whirl as a first big to fix. Is a patch submitted here good, or a branch and a merge request?  I did a quick tour of mdn and didn't see guidelines for submitting patches

Comment 3

[Andi [:andi]]

(In reply to psnyde2 from comment #2)
> Sure, if someone didn't mind doing a bit of handholding, I'd like to give it
> a whirl as a first big to fix. Is a patch submitted here good, or a branch
> and a merge request?  I did a quick tour of mdn and didn't see guidelines
> for submitting patches
The protocol is to upload patches here, ask for a review and after that mark the patch for checkin-needed. A list with reviewers for each module can be found here: https://wiki.mozilla.org/Modules/All

Comment 4

[psnyde2]

Attachment: Bug 1315438 - fix path for media/kiss_fft

Comment 5

[psnyde2]

(In reply to Andi-Bogdan Postelnicu from comment #3)
> (In reply to psnyde2 from comment #2)
> > Sure, if someone didn't mind doing a bit of handholding, I'd like to give it
> > a whirl as a first big to fix. Is a patch submitted here good, or a branch
> > and a merge request?  I did a quick tour of mdn and didn't see guidelines
> > for submitting patches
> The protocol is to upload patches here, ask for a review and after that mark
> the patch for checkin-needed. A list with reviewers for each module can be
> found here: https://wiki.mozilla.org/Modules/All

Thank you for cluing me in on the procedure.  This is good to go for a review then.  I don't see any formal way of requesting a review, so I'm hoping doing so in this text is sufficient.

Comment 6

[Andi [:andi]]

(In reply to psnyde2 from comment #5)
> (In reply to Andi-Bogdan Postelnicu from comment #3)
> > (In reply to psnyde2 from comment #2)
> > > Sure, if someone didn't mind doing a bit of handholding, I'd like to give it
> > > a whirl as a first big to fix. Is a patch submitted here good, or a branch
> > > and a merge request?  I did a quick tour of mdn and didn't see guidelines
> > > for submitting patches
> > The protocol is to upload patches here, ask for a review and after that mark
> > the patch for checkin-needed. A list with reviewers for each module can be
> > found here: https://wiki.mozilla.org/Modules/All
> 
> Thank you for cluing me in on the procedure.  This is good to go for a
> review then.  I don't see any formal way of requesting a review, so I'm
> hoping doing so in this text is sufficient.

We're almost there, bu there are some things that need to be changed:

1. Add a reviewer to the patch by going to the patch details and in the review section add peer and mark it as r?
2. Here at Mozilla we have the patch title standardised as:
            [Bugzilla ID] - [Patch Description]
   For this patch in particular a good title is:
            Bug 1315438 - fix path for media/kiss_fft

For start a Michael - [e-mail] is a good reviewer for this patch.

Comment 7

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8807925 [details] [diff] [review]
Bug 1315438 - fix path for media/kiss_fft

Review of attachment 8807925 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me! Thanks for the patch :)

When you're ready to check in the patch, add the keyword 'checkin-needed' under the tracking section to this bug, and a sheriff will come by and check it in for you.

Comment 8

[psnyde2]

Done, thanks much!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

In the future, please make sure you've got Mercurial configured to generate patches with the proper commit information. The |./mach mercurial-setup| command automates the process, otherwise you can do so manually following the directions below:
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Thanks for the patch!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a19077a2bd28
Fix the path to kiss_fft in the third party library list. r=mystor

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a19077a2bd28