1315495 - Uplift WASAPI leak fix from PR 183

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect)

Description

[Matthew Gregan [:kinetik]]

Spun off from bug 1314496 comment 14.

This is a simple leak for input and full-duplex streams: https://github.com/kinetiknz/cubeb/pull/183

Since full_duplex is only enabled on aurora and central, this will only need uplift to aurora once it lands on central.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: bug1315495.patch

Comment 2

[Alex Chronopoulos [:achronop]]

Comment on attachment 8807915 [details] [diff] [review]
bug1315495.patch

Looks good, thanks. Part of it already reviewed in https://github.com/kinetiknz/cubeb/pull/183

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d84108f190ee
Update libcubeb to 98b189d2.  r=achronop

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: bug1315495_aurora.patch

Approval Request Comment
[Feature/regressing bug #]: bug 1251502
[User impact if declined]: memory leak when using capture or full-duplex audio
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: zero risk, very simple additional release of capture_client resource
[String/UUID change made/needed]: none

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d84108f190ee

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8807920 [details] [diff] [review]
bug1315495_aurora.patch

Fix a memory leak. Take it in 51 aurora.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a1243da2fec4