Closed Bug 1315495 Opened 8 years ago Closed 8 years ago

Uplift WASAPI leak fix from PR 183

Categories

(Core :: Audio/Video: cubeb, defect)

Product:
Core
Component:
Audio/Video: cubeb
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

Details

Attachments

(2 files)

bug1315495.patch
2.33 KB, patch
achronop
: review+
Details | Diff | Splinter Review
bug1315495_aurora.patch
2.89 KB, patch
gchang
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Spun off from bug 1314496 comment 14.

This is a simple leak for input and full-duplex streams: https://github.com/kinetiknz/cubeb/pull/183

Since full_duplex is only enabled on aurora and central, this will only need uplift to aurora once it lands on central.
See Also: → 1314496
Attached patch bug1315495.patch — — Splinter Review 

        Attachment #8807915 -
        Flags: review?(achronop)

    
    

    
  
Comment on attachment 8807915 [details] [diff] [review]
bug1315495.patch

Looks good, thanks. Part of it already reviewed in https://github.com/kinetiknz/cubeb/pull/183

        Attachment #8807915 -
        Flags: review?(achronop) → review+

    
    

    
  
Pushed by mgregan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d84108f190ee
Update libcubeb to 98b189d2.  r=achronop

    
    

    
  


  
Approval Request Comment
[Feature/regressing bug #]: bug 1251502
[User impact if declined]: memory leak when using capture or full-duplex audio
[Describe test coverage new/current, TreeHerder]: n/a
[Risks and why]: zero risk, very simple additional release of capture_client resource
[String/UUID change made/needed]: none

        Attachment #8807920 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/d84108f190ee
Status: ASSIGNED → RESOLVED
Closed: 8 years ago

          status-firefox52:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

    
    

    
  
Comment on attachment 8807920 [details] [diff] [review]
bug1315495_aurora.patch

Fix a memory leak. Take it in 51 aurora.

        Attachment #8807920 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: