Closed Bug 1315513 Opened 8 years ago Closed 6 years ago

Intermittent toolkit/components/extensions/test/xpcshell/test_ext_alarms_replaces.js | test_duplicate_alarm_name_replaces_alarm - [test_duplicate_alarm_name_replaces_alarm : 92] duplicate named alarm replaced existing alarm - false == true

Categories

(WebExtensions :: General, defect, P3)

Product:
WebExtensions
Component:
General
Type:
defect

Tracking

(firefox63 fixed, firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox63 --- fixed
firefox64 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: robwu)

Details

(Keywords: bulk-close-intermittents, intermittent-failure)

Attachments

(1 file)

Bug 1315513 - Replace test_ext_alarms_replaces with reliable test
46 bytes, text/x-phabricator-request
aswan
: review+
Details | Review
Component: WebExtensions: Untriaged → WebExtensions: General
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 7 years ago
Keywords: bulk-close-intermittents
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 7 years ago → 6 years ago
Resolution: --- → INCOMPLETE
Product: Toolkit → WebExtensions
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 6 years ago → 6 years ago
Resolution: --- → INCOMPLETE
Fail reappeared on central.

Log link:  https://treeherder.mozilla.org/logviewer.html#?job_id=192565580&repo=mozilla-central&lineNumber=1871
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
This failure occurs when the tests run so slow, that the timer is triggered before the test can replace it again.
I'm going to replace the test with one that is not sensitive to the system load.
Assignee: nobody → rob
Status: REOPENED → ASSIGNED
The original test_ext_alarms_replaces test was sensitive to system loads
that slowed down the execution of the test, resulting in intermittent
failures.

This new test tests the equivalent behavior (namely that calling
browser.alarms.create replaces a previous alarm), without being
sensitive to system load. This is achieved by creating a repeating alarm
and immediately replacing this alarm with a one-shot alarm that runs
later than the original alarm.
Comment on attachment 9005259 [details]
Bug 1315513 - Replace test_ext_alarms_replaces with reliable test

Andrew Swan [:aswan] has approved the revision.
Attachment #9005259 - Flags: review+
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/a3deb2827c8e
Replace test_ext_alarms_replaces with reliable test r=aswan
Interesting. Waiting for the listener causes MessageChannel.jsm to trigger the "Message manager disconnected" error because API:RunListener does not return until promise of the onAlarms event handler resolves. When the extension is shut down at the end of the test, this error occurs.

Not something to worry about, I'll add it to the promise ignore list. Hopefully fixed when MessageChannel.jsm goes away.
Flags: needinfo?(rob)
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/c8d3a0f2f2b0
Replace test_ext_alarms_replaces with reliable test r=aswan
https://hg.mozilla.org/mozilla-central/rev/c8d3a0f2f2b0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago → 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: