1315522 - Marionette command-line option --addon does not work

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Martin Kimmerle]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20160921204512

Steps to reproduce:

Run:
/testing/marionette/harness/marionette/runner/base.py --addon=/path/to/any/addon.xpi


Actual results:

The addon doesn't get installed in the profile.


Expected results:

The addon should have been installed in the profile.

Tracking down the issue:
- BaseMarionetteArguments has the --addon option, which will map to `addon` [1].
- BaseMarionetteTestRunner accepts an `addons` parameter [2].
=> The --addon option should map to `addons` (plural), just like MozProfileCLI [3].

[1] https://dxr.mozilla.org/mozilla-central/rev/8e8b146fcb8b268e3c09b646087c6b2ef9f0af6f/testing/marionette/harness/marionette/runner/base.py#297
[2] https://dxr.mozilla.org/mozilla-central/rev/8e8b146fcb8b268e3c09b646087c6b2ef9f0af6f/testing/marionette/harness/marionette/runner/base.py#515
[3] https://dxr.mozilla.org/mozilla-central/rev/8e8b146fcb8b268e3c09b646087c6b2ef9f0af6f/testing/mozbase/mozprofile/mozprofile/cli.py#41

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thank you Martin for this bug report. As it looks like this is a regression from bug 1163801 which covered the move from optparse to argparse.

The underlying problem looks to be easy to fix. What we definitely need here is a harness unit test which makes sure that we do not regress it again.

Maja, mind mentoring that bug?

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

The harness test is going to be a little more involved, so I'll just submit a patch for this and file a follow-up mentored bug for the test.

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: Bug 1315522 - Marionette command-line option --addon does not work;

Review commit: https://reviewboard.mozilla.org/r/91068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91068/

Comment 4

[David Burns :automatedtester]

Comment on attachment 8808216 [details]
Bug 1315522 - Marionette command-line option --addon does not work;

https://reviewboard.mozilla.org/r/91068/#review90950

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b8386ff9818f
Marionette command-line option --addon does not work; r=automatedtester

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b8386ff9818f