Closed Bug 1315524 Opened 3 years ago Closed 3 years ago

Clear sessionStorage when clearing cookies on clean shutdown

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: ke5trel, Assigned: ke5trel)

References

Details

(Keywords: privacy)

Attachments

(1 file)

The privacy options to clear cookies on shutdown currently clear session cookies (Bug 529899 & Bug 1260360) but not sessionStorage despite it functioning much the same. sessionStorage is lost when tabs are closed but if the user keeps reusing the same tabs with the same websites across sessions (eg pinned tabs) then it can persist for long periods of time (eternalsession - Bug 530594).
Depends on: 1260360
Keywords: privacy
Will need assistance with try push.
Attachment #8807934 - Flags: review?(mdeboer)
Status: UNCONFIRMED → NEW
Ever confirmed: true
In bug 529899 comment 0 you mentioned that sessionStorage should also be cleared on a clean shutdown, but the bug actually only implemented clearing of cookies.
Kestrel here has implemented the missing part - is this something you'd still like to include?
Assignee: nobody → kestrel
Status: NEW → ASSIGNED
Flags: needinfo?(dveditz)
Comment on attachment 8807934 [details] [diff] [review]
bug1315524.patch - Clear sessionStorage when expiring or sanitizing cookies on clean shutdown

Review of attachment 8807934 [details] [diff] [review]:
-----------------------------------------------------------------

I don't see any problems - thanks Kestrel! r=me pending a reply from Daniel.
Attachment #8807934 - Flags: review?(mdeboer) → review+
(In reply to Mike de Boer [:mikedeboer] from comment #2)
> Kestrel here has implemented the missing part - is this something you'd
> still like to include?

I still think this is the right thing to do, yes.
Flags: needinfo?(dveditz)
WAK! This totally slipped passed my radar for a while! My apologies, Kestrel, will land soon!
Flags: needinfo?(mdeboer)
That makes two of us. :P 

Try looks good.
Whiteboard: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba7751450a45
Clear sessionStorage when expiring or sanitizing cookies on clean shutdown. r=mikedeboer
Whiteboard: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ba7751450a45
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Flags: needinfo?(mdeboer)
You need to log in before you can comment on or make changes to this bug.