#PanelUI-update-status[update-status]::after should have margin-inline-end instead of margin-right

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Theme
VERIFIED FIXED
7 months ago
12 days ago

People

(Reporter: Towkir, Assigned: Towkir, Mentored)

Tracking

({good-first-bug, rtl})

unspecified
Firefox 52
good-first-bug, rtl
Points:
---

Firefox Tracking Flags

(firefox52 verified)

Details

(Whiteboard: [good first bug][lang=css])

Attachments

(3 attachments)

(Assignee)

Description

7 months ago
Created attachment 8807979 [details]
padding_rtl.png

The PanelUI-update-status button should have a padding-inline-end of same value as padding-inline-start otherwise RTL builds shows something like "padding_rtl.png" which should look same as LTR builds ("padding_ltr.png")


I think "padding-inline-end: 15px;" after this line at:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#693 fixes the issue.
(Assignee)

Comment 1

7 months ago
Created attachment 8807980 [details]
padding_ltr.png

Here is the LTR (expected padding) attached.

Gijs, can you have a look at this ?
Flags: needinfo?(gijskruitbosch+bugs)
(Assignee)

Comment 2

7 months ago
As it relates to RTL
Keywords: rtl

Comment 3

7 months ago
Your selected fix is not quite right. Instead, we should fix this line: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#568

to use margin-inline-end: instead of margin-right.
Mentor: gijskruitbosch+bugs@gmail.com
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: good-first-bug
Summary: PanelUI-update-status should have padding-inline-end → #PanelUI-update-status[update-status]::after should have margin-inline-end instead of margin-right
Whiteboard: [good first bug][lang=css]
(Assignee)

Comment 4

7 months ago
Created attachment 8808448 [details] [diff] [review]
paneluiupdatestatus.patch

Hope this helps :)
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Attachment #8808448 - Flags: review?(gijskruitbosch+bugs)

Comment 5

7 months ago
Comment on attachment 8808448 [details] [diff] [review]
paneluiupdatestatus.patch

Review of attachment 8808448 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8808448 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 6

7 months ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/320a0f17371d
#PanelUI-update-status[update-status]::after should have margin-inline-end instead of margin-right; r=gijs
https://hg.mozilla.org/mozilla-central/rev/320a0f17371d
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Comment 8

13 days ago
I have reproduced this bug with Nightly 52.0a1 (2016-11-06) on Windows 10, 64 bit!

The fix is now verified on Nightly 55.0a1

Build ID 	20170512030203
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170512]

Updated

12 days ago
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.