Closed
Bug 1315550
Opened 8 years ago
Closed 8 years ago
#PanelUI-update-status[update-status]::after should have margin-inline-end instead of margin-right
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | verified |
People
(Reporter: Towkir, Assigned: Towkir, Mentored)
Details
(Keywords: good-first-bug, rtl, Whiteboard: [good first bug][lang=css])
Attachments
(3 files)
padding_rtl.png
The PanelUI-update-status button should have a padding-inline-end of same value as padding-inline-start otherwise RTL builds shows something like "padding_rtl.png" which should look same as LTR builds ("padding_ltr.png")
I think "padding-inline-end: 15px;" after this line at:
https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#693 fixes the issue.
|
Assignee | |
Comment 1•8 years ago
|
||
Here is the LTR (expected padding) attached. Gijs, can you have a look at this ?
Flags: needinfo?(gijskruitbosch+bugs)
|
||
Comment 3•8 years ago
|
||
Your selected fix is not quite right. Instead, we should fix this line: https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/customizableui/panelUI.inc.css#568 to use margin-inline-end: instead of margin-right.
Mentor: gijskruitbosch+bugs
Flags: needinfo?(gijskruitbosch+bugs)
Keywords: good-first-bug
Summary: PanelUI-update-status should have padding-inline-end → #PanelUI-update-status[update-status]::after should have margin-inline-end instead of margin-right
Whiteboard: [good first bug][lang=css]
|
|
Assignee | |
Comment 4•8 years ago
|
||
Hope this helps :)
Assignee: nobody → 3ugzilla
Status: NEW → ASSIGNED
Attachment #8808448 -
Flags: review?(gijskruitbosch+bugs)
|
|
||
Comment 5•8 years ago
|
||
Comment on attachment 8808448 [details] [diff] [review] paneluiupdatestatus.patch Review of attachment 8808448 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!
Attachment #8808448 -
Flags: review?(gijskruitbosch+bugs) → review+
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/320a0f17371d #PanelUI-update-status[update-status]::after should have margin-inline-end instead of margin-right; r=gijs
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/320a0f17371d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Comment 8•7 years ago
|
||
I have reproduced this bug with Nightly 52.0a1 (2016-11-06) on Windows 10, 64 bit! The fix is now verified on Nightly 55.0a1 Build ID 20170512030203 User Agent Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0 [testday-20170512]
|
|
||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•