Closed Bug 1315567 Opened 9 years ago Closed 9 years ago

Expose FLAC in mp4

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(4 files)

Bug 1315567: P1. Remove invalid test.
58 bytes, text/x-review-board-request
mozbugz
: review+
gchang
: approval-mozilla-aurora+
Details
Bug 1315567: P2. Expose opus codec as being available in mp4.
58 bytes, text/x-review-board-request
mozbugz
: review+
Details
Bug 1315567: P3. Expose flac codec as being available in mp4.
58 bytes, text/x-review-board-request
mozbugz
: review+
Details
Bug 1315567: P4. Add mochitest.
58 bytes, text/x-review-board-request
mozbugz
: review+
Details
CanPlayType and MediaSource IsTypeSupported do not expose FLAC has being available.
Comment on attachment 8808010 [details] Bug 1315567: P2. Expose opus codec as being available in mp4. https://reviewboard.mozilla.org/r/90922/#review90654 ::: dom/media/fmp4/MP4Decoder.cpp:1 (Diff revision 1) > /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ Commit description: 'available.in' -> 'available in'
Attachment #8808010 - Flags: review?(gsquelart) → review+
Comment on attachment 8808011 [details] Bug 1315567: P3. Expose flac codec as being available in mp4. https://reviewboard.mozilla.org/r/90924/#review90656 ::: dom/media/fmp4/MP4Decoder.cpp:1 (Diff revision 1) > /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ Commit description: 'available.in' -> 'available in'
Attachment #8808011 - Flags: review?(gsquelart) → review+
Comment on attachment 8808009 [details] Bug 1315567: P1. Remove invalid test. https://reviewboard.mozilla.org/r/90920/#review90664 r+ after you remove config_android.h. ::: media/ffvpx/config_android.h:1 (Diff revision 2) > +/* Automatically generated by configure - do not modify! */ I don't think this file should be in this commit/bug!
Attachment #8808009 - Flags: review?(gsquelart) → review+
Pushed by jyavenard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d7fec66162b7 P1. Remove invalid test. r=gerald https://hg.mozilla.org/integration/autoland/rev/d5ae76734cb6 P2. Expose opus codec as being available in mp4. r=gerald https://hg.mozilla.org/integration/autoland/rev/bfaa975490cf P3. Expose flac codec as being available in mp4. r=gerald https://hg.mozilla.org/integration/autoland/rev/eb1b930cef78 P4. Add mochitest. r=gerald
Comment on attachment 8808009 [details] Bug 1315567: P1. Remove invalid test. Approval Request Comment [Feature/regressing bug #]: 1303888 [User impact if declined]: this is required to get bug 1303888. Otherwise we don't advertise that we support FLAC in MP4/MSE [Describe test coverage new/current, TreeHerder]: In central, confirmed by our partner to work [Risks and why]: very low, we expose a working feature as being available. [String/UUID change made/needed]: None
Attachment #8808009 - Flags: approval-mozilla-aurora?
Comment on attachment 8808009 [details] Bug 1315567: P1. Remove invalid test. Support flac in mp4. Take it in 51 aurora.
Attachment #8808009 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(In reply to Gerry Chang [:gchang] from comment #21) > Comment on attachment 8808009 [details] > Bug 1315567: P1. Remove invalid test. > > Support flac in mp4. Take it in 51 aurora. is this just for change or do we need the 3 changsets too ?
Flags: needinfo?(jyavenard)
We need the other changesets too. Please uplift all four patches.
Flags: needinfo?(jyavenard)
Nevermind. P1 doesn't apply cleanly. I have a backport and will push after local testing.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: