1315582 - Try recreate ImageContainer IPDL objects before creating Images

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: rebuild-image-client

These functions get called from the media threads, and sometimes we've lost the IPDL objects due to a crash.

We then assert in TextureClient::CreateForYCbCr because our allocator is dead.

This is a band-aid (since we're checking for validity on the wrong thread, and it could change between now and when we actually use it), but it does fix a common crash.

Fixing this properly isn't simple, but probably worth doing.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8808023 [details] [diff] [review]
rebuild-image-client

Review of attachment 8808023 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, we should fix this... could you file a follow-up to at least get it on record? From a sample size of 1: cleaning up raciness of async layers has fixed real crashes.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3677545baae2
Try recreate ImageContainer IPDL object before creating Images. r=dvander

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3677545baae2