1315594 - Crash in java.lang.IllegalArgumentException: Menu item with ID=2131296712 not handled at org.mozilla.gecko.home.activitystream.menu.ActivityStreamContextMenu.onNavigationItemSelected(ActivityStreamContextMenu.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Nicholas Nethercote [inactive]]

This bug was filed from the Socorro interface and is 
report bp-5be3e3ab-fadd-4a4e-ab39-3c3e62161105.
=============================================================

This crash first showed up in Nightly 20161101030207. Since then it has occurred 7 times across 3 installations.

snorp, any ideas? (I would have asked jchen but he's on PTO.)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

This is from the activity stream context menu.

@ahunt: Can you take a look?

Comment 2

[Andrzej Hunt :ahunt]

Sigh, I forgot a "break" for delete:
https://dxr.mozilla.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/home/activitystream/menu/ActivityStreamContextMenu.java#239

Comment 3

[Andrzej Hunt :ahunt]

Attachment: Bug 1315594 - Add missing break

I'm not quite sure when this slipped in - and I probably didn't test carefully enough.

Review commit: https://reviewboard.mozilla.org/r/91054/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91054/

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8808143 [details]
Bug 1315594 - Add missing break

https://reviewboard.mozilla.org/r/91054/#review90776

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b6afc878dd4
Add missing break r=sebastian

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2b6afc878dd4