1315627 - Quickly switching between browsing sessions and opening a new tab will cause Fennec to crash

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Attachment: Client 07-11-16 11-10.crash

Build: 1bc8bb71f
Device: 
iPad Pro (9.3.2)
iPad Air 2 (10.0.3)

Steps to reproduce"
1. Launch Fennec
2. Quickly tap on 'Private Browsing' button
3. While switching between browsing session tap the 'New tab' button
4. Repeat steps 2 and 3

Actual results:
- Fennec will crash. I noticed that when opening a new tab(Tapping on the + button) the privacy toggle button is disabled, but when tapping quickly on this button (switching between browsing sessions) the 'Open new tab' button is still enabled which will cause the crash to occur. 

Expected:
- A solution might be to disable the 'New tab' button when the 'privacy toggle button' is animated and re-enable the button after the animation occurs. 

See video of the issue: https://www.youtube.com/watch?v=clubVyTfQMQ

Comment 1

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/51c7e1dbd2ee4ee0463ebf5e9867454a69840412

Comment 2

[Simon Basca [:SimonB]]

Attachment: I have tested this on latest Nightly 51abcc7ca and I can still reproduce this issue following the STR from the description. This crash log looks similar with Bug 1303322. Is this a duplicate issue?

Comment 3

[Farhan Patel [:farhan]]

Attachment: Pull Request

I've got a new PR to fix this. :crossesfingers:

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on master d0149e93.