Closed Bug 1315635 Opened 3 years ago Closed 3 years ago

Netmonitor Performance View: selecting item in the pie chart doesn't work, TypeError in console

Categories

(DevTools :: Netmonitor, defect, P1)

defect

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 verified)

VERIFIED FIXED
Firefox 52
Iteration:
52.3 - Nov 14
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- verified

People

(Reporter: jsnajdr, Assigned: jsnajdr)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [netmonitor])

Attachments

(1 file)

STR:
1. Open Netmonitor Performance View
2. Click on one of the pie chart slices

Expected:
The view is returned to the request list view, the request type from the clicked slice is selected as a filter

Actual:
Nothing happens, TypeError in console:
TypeError: Actions.enableFilterOnly is not a function: PerformanceStatisticsView.prototype._createChart/<@resource://devtools/client/netmonitor/performance-statistics-view.js:147:27

Regression from bug 1309192, where Actions.enableFilterOnly was renamed to Actions.enableFilterTypeOnly and one usage site wasn't updated.

Also, the test browser_net_statistics-03.js should be failing here, but it isn't - let's fix it.
Assignee: nobody → jsnajdr
Flags: qe-verify+
Keywords: regression
Priority: -- → P1
Whiteboard: [netmonitor]
Fixed the enableFilterTypeOnly action name.

Also, fixed the test that should have failed but didn't:

Added checks if the frontend is in the right mode (inspector vs. statistics).

Fixed the testFilterButtons to query the button elements with the correct CSS selector. It was using a wrong, outdated one (.request-menu-footer-buttons) that returned zero elements. Then, check that some elements were actually found. Until now, the test passed silently when testing zero elements.
Priority: P1 → --
QA Contact: ciprian.georgiu
Whiteboard: [netmonitor] → [netmonitor] [triage]
Comment on attachment 8808137 [details]
Bug 1315635 - Netmonitor Performance View: fixed name of enableFilterTypeOnly action

https://reviewboard.mozilla.org/r/91050/#review90830

LGTM, thanks Jarda!
Honza
Attachment #8808137 - Flags: review?(odvarko) → review+
Pushed by jsnajdr@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a2484fe7cfc4
Netmonitor Performance View: fixed name of enableFilterTypeOnly action r=Honza
Status: NEW → ASSIGNED
Iteration: --- → 52.3 - Nov 14
Priority: -- → P1
Whiteboard: [netmonitor] [triage] → [netmonitor]
Depends on: 1315833
https://hg.mozilla.org/mozilla-central/rev/a2484fe7cfc4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Reproduced the issue on an Nightly build from 2016-11-07, Win10.

This is verified fixed on latest Nightly 52.0a1 (2016-11-08) across platforms:
- Windows 10 x64
- Ubuntu 14.04 x86
- Mac OS X 10.11
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Version: unspecified → Trunk
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.