1315635 - Netmonitor Performance View: selecting item in the pie chart doesn't work, TypeError in console

Status: VERIFIED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Jarda Snajdr [:jsnajdr]]

STR:
1. Open Netmonitor Performance View
2. Click on one of the pie chart slices

Expected:
The view is returned to the request list view, the request type from the clicked slice is selected as a filter

Actual:
Nothing happens, TypeError in console:
TypeError: Actions.enableFilterOnly is not a function: PerformanceStatisticsView.prototype._createChart/<@resource://devtools/client/netmonitor/performance-statistics-view.js:147:27

Regression from bug 1309192, where Actions.enableFilterOnly was renamed to Actions.enableFilterTypeOnly and one usage site wasn't updated.

Also, the test browser_net_statistics-03.js should be failing here, but it isn't - let's fix it.

Comment 1

[Jarda Snajdr [:jsnajdr]]

Attachment: Bug 1315635 - Netmonitor Performance View: fixed name of enableFilterTypeOnly action

Review commit: https://reviewboard.mozilla.org/r/91050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/91050/

Comment 2

[Jarda Snajdr [:jsnajdr]]

Fixed the enableFilterTypeOnly action name.

Also, fixed the test that should have failed but didn't:

Added checks if the frontend is in the right mode (inspector vs. statistics).

Fixed the testFilterButtons to query the button elements with the correct CSS selector. It was using a wrong, outdated one (.request-menu-footer-buttons) that returned zero elements. Then, check that some elements were actually found. Until now, the test passed silently when testing zero elements.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8808137 [details]
Bug 1315635 - Netmonitor Performance View: fixed name of enableFilterTypeOnly action

https://reviewboard.mozilla.org/r/91050/#review90830

LGTM, thanks Jarda!
Honza

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2484fe7cfc4
Netmonitor Performance View: fixed name of enableFilterTypeOnly action r=Honza

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a2484fe7cfc4

Comment 6

[Ciprian Georgiu, Desktop QA]

Reproduced the issue on an Nightly build from 2016-11-07, Win10.

This is verified fixed on latest Nightly 52.0a1 (2016-11-08) across platforms:
- Windows 10 x64
- Ubuntu 14.04 x86
- Mac OS X 10.11