Missing referrer handling test for openURIInFrame in browser.js

NEW
Unassigned

Status

()

Firefox
Tabbed Browser
P3
normal
2 years ago
2 years ago

People

(Reporter: bobowen, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox52 affected)

Details

(Reporter)

Description

2 years ago
The aParams.referrer in openURIInFrame is/was being passed through to _openURIInNewTab as a string, when it expects a URI.

A test should be added to catch this (see bug 1147911 comment 19).

It possibly wasn't causing a problem because we were only currently calling openURIInFrame with a null aURI, which I think meant the referrer was not used in a way that caused a problem.

Comment 1

2 years ago
Maybe we should just remove the param if it's always null?
Priority: -- → P3
(Reporter)

Comment 2

2 years ago
(In reply to :Gijs Kruitbosch from comment #1)
> Maybe we should just remove the param if it's always null?

Hopefully, I'll be using it in bug 1147911 patch part 7.
You need to log in before you can comment on or make changes to this bug.