Open Bug 1315649 Opened 3 years ago Updated 3 years ago

Missing referrer handling test for openURIInFrame in browser.js

Categories

(Firefox :: Tabbed Browser, defect, P3)

defect

Tracking

()

Tracking Status
firefox52 --- affected

People

(Reporter: bobowen, Unassigned)

Details

The aParams.referrer in openURIInFrame is/was being passed through to _openURIInNewTab as a string, when it expects a URI.

A test should be added to catch this (see bug 1147911 comment 19).

It possibly wasn't causing a problem because we were only currently calling openURIInFrame with a null aURI, which I think meant the referrer was not used in a way that caused a problem.
Maybe we should just remove the param if it's always null?
Priority: -- → P3
(In reply to :Gijs Kruitbosch from comment #1)
> Maybe we should just remove the param if it's always null?

Hopefully, I'll be using it in bug 1147911 patch part 7.
You need to log in before you can comment on or make changes to this bug.