Closed Bug 1315671 Opened 8 years ago Closed 2 months ago

Remove templates from MacroAssembler.h

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: lth, Unassigned)

Details

In bug 1268002 I introduced some templated functions in MacroAssembler.h (for cmp32Set and cmpPtrSet), since these were templated in all the platform assemblers and there were other templated interfaces in MacroAssembler.h already.

However, nbp says he prefers for there not to be templated interfaces in that file (and I agree that it's a good idea to avoid them).

So clean it up: get rid of the templates.

Extra credit: make check_macroassembler_style.py recognize templates and forbid them.
Severity: normal → S3

This ship seems to have sailed...

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.