1315673 - Browser restart sometimes loses containers

Status: RESOLVED INVALID

(Core :: DOM: Security, defect, P1)

Description

[Richard Barnes [:rbarnes]]

Running Nightly, I have noticed that sometimes when I "restart to update", when the tabs are created in the new browser window, they have the correct URLs, but they are all loaded in the default container (i.e., not colored bar at the top).  

So for example, if you had 2 Gmail accounts open in tabs, account A in container X and account B in the default container, then on browser restart you would get two default container tabs with account B loaded.

Instead, I would expect the new browser window to load the two tabs with the same container assignments as before restart, one tab with container X with account A loaded, and one tab with the default container and account B.

Comment 1

[Tanvi Vyas[:tanvi]]

If this is true, this is not good.  It leaks data across Containers.

Needinfo'ing Kamil to test this.

Comment 2

[Kamil Jozwiak [:kjozwiak]]

Richard, which platform were you using when you noticed this happening? Did you set any preferences, for example, "Show my windows and tabs from last time"?

Comment 3

[Richard Barnes [:rbarnes]]

Platform is MacOS 10.11.6.

I don't think I have any special preferences set.  

Note: I haven't seen this recently, so it might have gone away.  Sorry I don't have cleaner STR.

Comment 4

[Kamil Jozwiak [:kjozwiak]]

Awesome, thanks :) I'll see if I can manage to reproduce this on my machine.

Comment 5

[Dave Huseby [:huseby]]

IIRC, there was some question about the correct way to handle the origin attributes in the session restore code.  We already have a regression documented in Bug 1291521.

Comment 6

[Tanvi Vyas[:tanvi]]

Richard, Kamil can't seem to reproduce this.  And I haven't heard about this issue elsewhere.  Should we close worksforme?

baku, are you aware of any open issues with the code for Session Restore for Containers?

Comment 7

[Richard Barnes [:rbarnes]]

I'm fine to close this as INVALID.  I haven't seen it lately either.