1315674 - Selecting a synced tab from the awesome bar should open a new tab rather than replacing the current tab, for consistency with "switch to tab"

Status: NEW

(Firefox :: Address Bar, defect, P3)

Description

[Brad Lassey [:blassey] (use needinfo?)]

I've associated that icon with "we'll switch tabs, not load something in this tab" but when it is a synced tab it loads the page in the tab you're in. Seems like we could have a little phone icon (and tablet, laptop, desktop icons where appropriate) to give an indication of where that tab is coming from.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Currently we show a generic "tab" icon, which is the same icon used for "switch to tab" - we should show an icon that best matches the device type the tab is open on.

We do already track the device type at https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/toolkit/components/places/PlacesRemoteTabsAutocompleteProvider.jsm#140.

However, when we add the match we ignore that and just add a generic "remotetab" class - https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/toolkit/components/places/UnifiedComplete.js#1698 - which is picked up by https://searchfox.org/mozilla-central/rev/f80722d4f3bfb722c5ec53880c4a7efb71285676/browser/themes/shared/urlbar-autocomplete.inc.css#110

So the fix seems simple - add remotetab *and* device class, and that CSS should select a more appropriate icon. I'm not sure if the icons we already have are suitable though...

Comment 2

[bbell]

(In reply to Brad Lassey [:blassey] (use needinfo?) from comment #0)

The "generic tab" icon is the correct icon on the ground that it's an open tab no matter the device, but you're right in that it should have consistent behavior and should load in a new tab.

Comment 3

[Ryan Feeley [:rfeeley]]

Agreed!