Closed
Bug 1315686
Opened 8 years ago
Closed 8 years ago
Possible name collision in UnsizedFormat enum class
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: petr.sumbera, Assigned: jgilbert)
Details
Attachments
(1 file, 1 obsolete file)
1.99 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (X11; SunOS i86pc; rv:45.0) Gecko/20100101 Firefox/45.0
Build ID: 20161020232743
Steps to reproduce:
There is following name collision on Solaris:
grep 'DS' /usr/include/sys/regset.h
#define DS 3
And Firefox in dom/canvas/WebGLFormats.h
enum class UnsizedFormat : uint8_t {
..
D,
S,
DS,
};
Using something other than DS would solve the problem.
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8808202 -
Flags: review?(dolske)
Updated•8 years ago
|
Component: Untriaged → Canvas: WebGL
Product: Firefox → Core
Updated•8 years ago
|
Attachment #8808202 -
Flags: review?(dolske) → review?(jgilbert)
Assignee | ||
Comment 2•8 years ago
|
||
What does "possible" mean here? The compiler should cleanly generate errors if this happened, I believe.
Flags: needinfo?(petr.sumbera)
Reporter | ||
Comment 3•8 years ago
|
||
The build on Solaris "always" fails because of this.
The "possible" was meant that beside Solaris there still may be some other OS with the same problem (though Linux/BSD/Mac are probably OK). If you think, I can change bug synopsis to:
Name collision in UnsizedFormat enum class on Solaris
Flags: needinfo?(petr.sumbera)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8808202 [details] [diff] [review]
Bug1315686.patch
Review of attachment 8808202 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/WebGLFormats.h
@@ +158,4 @@
> A,
> D,
> S,
> + DEPTH_STENCIL,
Add // `DS` is a macro on Solaris.
Attachment #8808202 -
Flags: review?(jgilbert) → review+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jgilbert
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee | ||
Comment 5•8 years ago
|
||
This is a small enough change that we can just take it. I'll take care of it from here.
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/142d256dc5f3
Rename DS to avoid macro conflict on Solaris. - r=jgilbert
Comment 7•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Assignee | ||
Updated•8 years ago
|
status-firefox51:
--- → affected
Assignee | ||
Updated•8 years ago
|
Reporter | ||
Comment 8•7 years ago
|
||
Attachment #8934495 -
Flags: review?(jgilbert)
Reporter | ||
Comment 9•7 years ago
|
||
Attachment #8934495 -
Flags: review?(jgilbert)
Reporter | ||
Updated•7 years ago
|
Attachment #8934495 -
Attachment is obsolete: true
Assignee | ||
Comment 10•7 years ago
|
||
Comment on attachment 8808202 [details] [diff] [review]
Bug1315686.patch
Review of attachment 8808202 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/canvas/WebGLFormats.h
@@ +158,4 @@
> A,
> D,
> S,
> + DEPTH_STENCIL,
Also please make this D_S
Assignee | ||
Comment 11•7 years ago
|
||
Oh, this is from forever ago. Disregard!
You need to log in
before you can comment on or make changes to this bug.
Description
•