1315755 - Crash: SentTo: BrowserProfile.history.getter +1868

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect, P1)

Description

[Stephan Leroux [:sleroux]]

Attachment: 2016-11-05_19-55-57.1487_-0400-6c6a26efc18955f7b1a6261915f3e477817ad3f4.crash

Firefox Beta 6.0 (2)
#2 in Xcode organizer 

Crash log attached.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: 2016-11-06_15-45-59.9619_+1000-fefeb57bd5679c07d304b48d353bcebb42e3523f.crash

Note: #3 crash in organizer looks like the same thing but originating from the ViewLater extension instead of SendTo.

Crash log attached.

Comment 2

[Stephan Leroux [:sleroux]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2230

Comment 3

[Richard Newman [:rnewman]]

Comment on attachment 8809419 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2230

Counter-proposal on the PR.

Comment 4

[Stephan Leroux [:sleroux]]

Comment on attachment 8809419 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/2230

Updated with the simpler approach. SQLiteHistory no longer failable and skip over create/update if we're closed.

Comment 5

[Richard Newman [:rnewman]]

Part of this change -- the short-circuiting on close -- should fix Bug 1317093. There are other recommendations in that bug that should also be addressed (e.g., quickly hitting Home on first ever run).

Comment 6

[Stephan Leroux [:sleroux]]

Sweet! I forgot I included that short circuit logic on that PR. That should resolve the empty case for now but I'll keep the bug open and add the layered fixes to it as part of that bug.

Comment 7

[Stephan Leroux [:sleroux]]

master https://github.com/mozilla-mobile/firefox-ios/commit/3ad25b2e51f538d68528c579979e5d1239e8bad0

Comment 8

[Stephan Leroux [:sleroux]]

v6.x f6e7ec22d9ce4d2c41c21f57b992d886946d3a06