1315863 - Flickering sync icon in menu

Status: VERIFIED FIXED

(Core :: ImageLib, defect, P3)

Description

[Winson Wen]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161107030203

Steps to reproduce:

Sign in to Firefox sync
Sync Firefox


Actual results:

Animated sync icon in Firefox menu is flickering when animating.


Expected results:

Icon animates without flickering.

Comment 1

[Winson Wen]

Using Mozregression-gui spat out this:

app_name: firefox
build_date: 2016-10-26 16:39:52.768000
build_file: C:\Users\Winson Wen\.mozilla\mozregression\persist\a27012791c9e--mozilla-inbound--firefox-52.0a1.en-US.win64.zip
build_type: inbound
build_url: https://queue.taskcluster.net/v1/task/NbAnpFt6SGS2ZLbEgFfv0A/runs/0/artifacts/public%2Fbuild%2Ffirefox-52.0a1.en-US.win64.zip
changeset: a27012791c9ed666cddc0e18be775d7e42bd2df0
pushlog_url: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d26ac63f1b81c3fce35448a7c502e95e0b5c56c0&tochange=a27012791c9ed666cddc0e18be775d7e42bd2df0
repo_name: mozilla-inbound
repo_url: https://hg.mozilla.org/integration/mozilla-inbound
task_id: NbAnpFt6SGS2ZLbEgFfv0A

Comment 2

[Justin [:JW_SoftvisionQA]]

Can you type "about:support" into the URL Bar and copy & paste your Graphics information.

Comment 3

[Winson Wen]

Graphics
Features
Compositing	Direct3D 11
Asynchronous Pan/Zoom	wheel input enabled; touch input enabled
WebGL Renderer	Google Inc. -- ANGLE (Intel(R) HD Graphics Direct3D11 vs_4_1 ps_4_1)
WebGL2 Renderer	Google Inc. -- ANGLE (Intel(R) HD Graphics Direct3D11 vs_4_1 ps_4_1)
Hardware H264 Decoding	Yes; D3D11 blacklisted with DLL igd10umd64.dll (9.17.10.4229); Using D3D9 API
Audio Backend	wasapi
Direct2D	true
DirectWrite	true (10.0.14393.351)
GPU #1
Active	Yes
Description	Intel(R) HD Graphics
Vendor ID	0x8086
Device ID	0x0106
Driver Version	9.17.10.4229
Driver Date	5-28-2015
Drivers	igdumd64 igd10umd64 igd10umd64 igdumd32 igd10umd32 igd10umd32
Subsys ID	21ed17aa
RAM	Unknown
Diagnostics
AzureCanvasAccelerated	0
AzureCanvasBackend	skia
AzureContentBackend	skia
AzureFallbackCanvasBackend	cairo
GPUProcessPid	956
GPUProcess	
Decision Log
D3D9_COMPOSITING	
disabled by default: Disabled by default

Comment 4

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 53.0a1 (2016-11-14) under Windows 10 64-bit and Ubuntu 16.04 32-bit.

See screencast: http://screencast.com/t/RLl5Ywg6

Last good revision: 31177ceb556cd662fa0dc7aaba12067243113355
First bad revision: a27012791c9ed666cddc0e18be775d7e42bd2df0
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=31177ceb556cd662fa0dc7aaba12067243113355&tochange=a27012791c9ed666cddc0e18be775d7e42bd2df0

Comment 5

[Julien Cristau [:jcristau]]

Marking 53 affected per comment 4.  This doesn't sound like a major bug, so marking fix-optional for 52.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

It is the image itself, and not any particular interaction with Firefox Sync and the popup displayed, so a simpler STR is:
1) Open browser/themes/linux/syncProgress-horizontalbar.png directly. Flickers.
2) Open browser/themes/linux/syncProgress-toolbar.png directly. Does not flicker with similar animation.

I tried backing out the libpng upgrade and it confirmed it fixes the flickering. I will look into what changed that could have broken this -- maybe a partially misapplied APNG patch (?)...

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Attachment: [DEBUG] Restore PNG_ZLIB_VERNUM to stop flickering

It appears that PNG_ZLIB_VERNUM was never defined. When libpng switched to checking ZLIB_VERNUM directly, those #ifdefs all of a sudden got enabled because that *is* defined in zlib.h. Attached patch reverts only those changes from the libpng upgrade and stops the flickering (not intended to land, just for debug).

Comment 8

[Andrew Osmond [:aosmond] (he/him)]

It looks like we need to set PNG_MAXIMUM_INFLATE_WINDOW in our decoder in order to decode that image properly. It was effectively set with the PNG_ZLIB_VERNUM define missing, but with ZLIB_VERNUM present, we need to explicitly set this.

Comment 9

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Use PNG_MAXIMUM_INFLATE_WINDOW option, v1

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c3d1edc99571cee32a96c868142e414189b4e657

Comment 10

[Glenn Randers-Pehrson]

Comment on attachment 8811442 [details] [diff] [review]
Use PNG_MAXIMUM_INFLATE_WINDOW option, v1

Looks OK

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/39806168b32d
Use PNG_MAXIMUM_INFLATE_WINDOW to ensure maximum compatibility with existing images. r=glennrp

Comment 12

[Timothy Nikkel (:tnikkel)]

Let's make sure this is uplifted so we don't ship this.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/39806168b32d

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 15

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8811442 [details] [diff] [review]
Use PNG_MAXIMUM_INFLATE_WINDOW option, v1

Approval Request Comment
[Feature/regressing bug #]: 1311776
[User impact if declined]: User will see the sync icon flickering. PNG interop in the wild may be reduced as some images can fail to decode that used to work.
[Describe test coverage new/current, TreeHerder]: Tried viewing the PNG on latest nightly, no longer flickers.
[Risks and why]: Very low risk. This patch merely restores original behaviour prior to regressing bug.
[String/UUID change made/needed]: N/A

Comment 16

[Vasilica Tamas, QA [:vtamas]]

Verified as fixed on Firefox 53.0a1 (2016-11-21) under Windows 10 64-bit and Ubuntu 16.04 32-bit. There are no longer UI issues displayed during the sync button rotation.

Comment 17

[Julien Cristau [:jcristau]]

Comment on attachment 8811442 [details] [diff] [review]
Use PNG_MAXIMUM_INFLATE_WINDOW option, v1

fix regression from libpng update in aurora52

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/81e6bda81ba5

Comment 19

[Vasilica Tamas, QA [:vtamas]]

Confirm that the sync icon spins without any UI issues also on Firefox 52.0a2 (2016-11-24) under Windows 10 64-bit and Ubuntu 16.04 32-bit.