1316000 - Remove old Yahoo! Messenger support

Status: RESOLVED FIXED

(Chat Core :: Yahoo! Messenger, defect)

Description

[Patrick Cloke [:clokep]]

The current Yahoo! Messenger code we have does not work.

I can't seem to find any reference to it, but Pidgin also removed support.

Comment 1

[Patrick Cloke [:clokep]]

A link to an announcement about this: https://web.archive.org/web/20160730080614/https://help.yahoo.com/kb/yahoo-messenger-for-web/SLN26860.html

Comment 2

[Patrick Cloke [:clokep]]

Attachment: Patch v1

I tested this by ensuring that yahoo didn't appear in the list of new accounts anymore. Trying to connect to Yahoo showed a message saying it doesn't work and didn't try to reconnect.

Comment 3

[aleth [:aleth]]

Comment on attachment 8808702 [details] [diff] [review]
Patch v1

Review of attachment 8808702 [details] [diff] [review]:
-----------------------------------------------------------------

Doesn't this also need a prpl patch? yahoo is still listed in purple/libpurple/moz.build

Looks good otherwise.

::: im/locales/en-US/chrome/instantbird/accountWizard.properties
@@ +7,5 @@
>  # to the target language / location and comma delimited.
>  # Exceeding 4 protocols may cause scrolling. A list of the
>  # available protocols can be found at
>  #     https://wiki.instantbird.org/Protocol_Identifiers
> +topProtocol.list=prpl-gtalk,prpl-twitter,prpl-aim,prpl-irc

How about replacing yahoo with XMPP?

Comment 4

[Patrick Cloke [:clokep]]

Attachment: Purple Patch v1

Remove both Yahoo and MySpace from libpurple. These have both been removed by Pidgin.

Comment 5

[Patrick Cloke [:clokep]]

Attachment: Patch v2

Added XMPP to the top protocols list.

Comment 6

[aleth [:aleth]]

Comment on attachment 8808978 [details] [diff] [review]
Purple Patch v1

Review of attachment 8808978 [details] [diff] [review]:
-----------------------------------------------------------------

rs+
I hope this doesn't bitrot the libpurple update patch that is waiting for flo's review too much...

Comment 7

[aleth [:aleth]]

Comment on attachment 8808995 [details] [diff] [review]
Patch v2

Review of attachment 8808995 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/9371fb54aca0ac6f5ef39ec2b047246b2dd9f005
https://hg.mozilla.org/users/florian_queze.net/purple/rev/b9d75e616955a6271c488a84443c14129ee666e1

Thanks!

Comment 9

[Patrick Cloke [:clokep]]

Oops, I had the wrong prpl ID in the account wizard:
https://hg.mozilla.org/comm-central/rev/dc1b2bd19227d32fbb4ef5d5ff7ebc12e1641079