Closed Bug 1316000 Opened 5 years ago Closed 5 years ago

Remove old Yahoo! Messenger support

Categories

(Chat Core :: Yahoo! Messenger, defect)

defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED
Instantbird 52

People

(Reporter: clokep, Assigned: clokep)

References

Details

Attachments

(2 files, 1 obsolete file)

The current Yahoo! Messenger code we have does not work.

I can't seem to find any reference to it, but Pidgin also removed support.
Assignee: nobody → clokep
Status: NEW → ASSIGNED
Attached patch Patch v1 (obsolete) — Splinter Review
I tested this by ensuring that yahoo didn't appear in the list of new accounts anymore. Trying to connect to Yahoo showed a message saying it doesn't work and didn't try to reconnect.
Attachment #8808702 - Flags: review?(aleth)
Comment on attachment 8808702 [details] [diff] [review]
Patch v1

Review of attachment 8808702 [details] [diff] [review]:
-----------------------------------------------------------------

Doesn't this also need a prpl patch? yahoo is still listed in purple/libpurple/moz.build

Looks good otherwise.

::: im/locales/en-US/chrome/instantbird/accountWizard.properties
@@ +7,5 @@
>  # to the target language / location and comma delimited.
>  # Exceeding 4 protocols may cause scrolling. A list of the
>  # available protocols can be found at
>  #     https://wiki.instantbird.org/Protocol_Identifiers
> +topProtocol.list=prpl-gtalk,prpl-twitter,prpl-aim,prpl-irc

How about replacing yahoo with XMPP?
Attached patch Purple Patch v1Splinter Review
Remove both Yahoo and MySpace from libpurple. These have both been removed by Pidgin.
Attachment #8808978 - Flags: review?(aleth)
Attached patch Patch v2Splinter Review
Added XMPP to the top protocols list.
Attachment #8808702 - Attachment is obsolete: true
Attachment #8808702 - Flags: review?(aleth)
Attachment #8808995 - Flags: review?(aleth)
Comment on attachment 8808978 [details] [diff] [review]
Purple Patch v1

Review of attachment 8808978 [details] [diff] [review]:
-----------------------------------------------------------------

rs+
I hope this doesn't bitrot the libpurple update patch that is waiting for flo's review too much...
Attachment #8808978 - Flags: review?(aleth) → review+
Comment on attachment 8808995 [details] [diff] [review]
Patch v2

Review of attachment 8808995 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8808995 - Flags: review?(aleth) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Instantbird 52
Oops, I had the wrong prpl ID in the account wizard:
https://hg.mozilla.org/comm-central/rev/dc1b2bd19227d32fbb4ef5d5ff7ebc12e1641079
Blocks: 1583944
You need to log in before you can comment on or make changes to this bug.