Closed Bug 1316096 Opened 3 years ago Closed 3 years ago

eslint rule values are not easy to interpret for those unfamiliar with the meaning of the values

Categories

(Toolkit :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: jaws, Assigned: jaws)

References

Details

Attachments

(1 file)

We should change the eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error.

0 is the same as "off"
1 is the same as "warn"
2 is the same as "error"
Comment on attachment 8808760 [details]
Bug 1316096 - Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error.

https://reviewboard.mozilla.org/r/91492/#review91612
Attachment #8808760 - Flags: review?(dtownsend) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ffd0e45ac58
Change eslint configuration to use string values for rules instead of integers, making it easier for others who are reading the rules to know if a rule is set to off, warn, or error. r=mossop
https://hg.mozilla.org/mozilla-central/rev/8ffd0e45ac58
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.