Closed Bug 1316217 Opened 8 years ago Closed 8 years ago

Add --enable-webrender compile option.

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54

People

(Reporter: mtseng, Assigned: mtseng)

References

Details

Add this option to include/exclude webrender easily. Also, we need ensure that all tests still pass without webrender.

Part of works in https://github.com/jrmuizel/gecko-dev/pull/21

and try run in https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0bccd887d8ef4be99314a462c44336335d64338&selectedJob=30639124

Still few tests failed, I'll look into it.
PR #21 has been merged, so I'm not sure if you want to close out this bug or not.
Assignee: nobody → mtseng
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #0)
> and try run in
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=d0bccd887d8ef4be99314a462c44336335d64338&selectedJob=3
> 0639124
> 
> Still few tests failed, I'll look into it.

Not sure if you had a chance to look into this. Just from the types of tests failing I'm assuming it's because APZ is disabled. In the wr-option2 PR that got merged today I put the APZAllowWithWebRender() check inside the MOZ_ENABLE_WEBRENDER guard so that shouldn't be a problem anymore. I also kicked off a new try push with the latest code from the WR branch (linux only for now):

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fded55fc173d04e8d69c2c84f2da68d04365c1c
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #2)
> (In reply to Morris Tseng [:mtseng] [:Morris] from comment #0)
> 
> Not sure if you had a chance to look into this. Just from the types of tests
> failing I'm assuming it's because APZ is disabled. In the wr-option2 PR that
> got merged today I put the APZAllowWithWebRender() check inside the
> MOZ_ENABLE_WEBRENDER guard so that shouldn't be a problem anymore. I also
> kicked off a new try push with the latest code from the WR branch (linux
> only for now):
> 
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=3fded55fc173d04e8d69c2c84f2da68d04365c1c

Yap, excluded the APZAllowWithWebRender() makes the test pass. I saw you've added this. Close this now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.