1316241 - [geckoview] Make WebRTC work with GeckoView

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Nick Alexander :nalexander [he/him]]

Right now, we have WebRTC in Fennec and not in GeckoView.  See https://dxr.mozilla.org/mozilla-central/source/mobile/android/geckoview/build.gradle?q=path%3Ageckoview%2Fbuild.gradle&redirect_type=single#42.

This ticket tracks moving that into GeckoView and figuring out what needs to be exposed to make it all work.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Kevin I think this should work, but do you wanna try it?

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Does not work in Klar Geckoview or geckoview example on a Pixel 2 XL.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Yeah, a simple GUM test[0] is not working here, at least with e10s. First I get a crash, but then after fixing that I have:

04-30 14:36:45.550  4931  4950 I Gecko   : [Child 4931, Main Thread] ###!!! ASSERTION: Cannot perform action in content process!: 'Error', file /home/snorp/source/gecko/extensions/cookie/nsPermissionManager.cpp, line 1696
04-30 14:36:45.551  4931  4950 E Web Content: [JavaScript Error: "Media device error: [Exception... "Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIPermissionManager.add]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: jar:jar:file:///data/app/org.mozilla.geckoview_example-fyeXVGIZjHvl59jv5JqgxQ==/base.apk!/assets/omni.ja!/components/GeckoViewPermission.js :: handleMediaRequest/</< :: line 131"  data: no]" {file: "jar:jar:file:///data/app/org.mozilla.geckoview_example-fyeXVGIZjHvl59jv5JqgxQ==/base.apk!/assets/omni.ja!/components/GeckoViewPermission.js" line: 147}]
04-30 14:36:45.551  4931  4950 E Web Content: handleMediaRequest/<@jar:jar:file:///data/app/org.mozilla.geckoview_example-fyeXVGIZjHvl59jv5JqgxQ==/base.apk!/assets/omni.ja!/components/GeckoViewPermission.js:147:7

So it looks like the permissions stuff needs split up into parent/child bits. Jim can you take a look?

[0] https://webrtc.github.io/samples/src/content/getusermedia/gum/

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1316241 - Fix media prompts with GeckoView

Looks like this got typoed during a rebase or something similar.
What are tests?

Review commit: https://reviewboard.mozilla.org/r/240830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240830/

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

The attached patch fixes it for non-e10s. I'll move the e10s bit over to bug 1458020.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8972118 [details]
Bug 1316241 - Fix media prompts with GeckoView

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240830/diff/1-2/

Comment 7

[Eugen Sawin [:esawin]]

Comment on attachment 8972118 [details]
Bug 1316241 - Fix media prompts with GeckoView

https://reviewboard.mozilla.org/r/240830/#review247360

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3550cb0d54d4
Fix media prompts with GeckoView r=esawin

Comment 9

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3550cb0d54d4

Comment 10

[Chris Peterson [:cpeterson]]

> Keywords: leave-open

James, does WebRTC work in GV 62? Why did you tag this bug as leave-open when landing your media prompts fix in May?

Comment 11

[James Willcox (:snorp) ([e-mail]) (he/him)]

It seems to be working in 62, yeah. I can't remember why I marked it leave-open. I guess because of the e10s case?

Comment 12

[contact]

Problem is not solved in: geckoview:73.0.20200211134023.

I get this error:

Error getting user media: The request is not allowed by the user agent or the platform in the current context. getUserMedia error: Failed to get access to local media. Error name was NotAllowedError. Continuing without sending a stream.

Comment 13

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to contact from comment #12)

Problem is not solved in: geckoview:73.0.20200211134023.

I get this error:

Error getting user media: The request is not allowed by the user agent or the platform in the current context. getUserMedia error: Failed to get access to local media. Error name was NotAllowedError. Continuing without sending a stream.

It looks like maybe you didn't respond to the content permission prompt? WebRTC does work in Fenix, so I don't think GeckoView has a general problem here.