1316247 - stylo: restyles generated during change hint processing should be handled in the same ProcessPendingRestyles call

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Cameron McCormack (:heycam)]

Some change hint processing causes new restyles to be posted, e.g. when processing a ReconstructFrame on a given element, and it's decided that we need to recreate frames for the parent, we call PostRestyleEvent for the parent with another ReconstructFrame change hint.  If we don't do this, then we can end up with the frame tree being in a state that has not fully taken account of the restyles until the next refresh driver tick.

The Gecko RestyleTracker::DoProcessRestyles method loops processing restyles until the restyle table is empty.  We should make ServoRestyleManager::ProcessPendingRestyles do the same.

Comment 1

[Cameron McCormack (:heycam)]

This case comes up in layout/reftests/table-anonymous-boxes/156888-1.html.

Comment 2

[Cameron McCormack (:heycam)]

Attachment: patch

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8808949 [details] [diff] [review]
patch

Review of attachment 8808949 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/ServoRestyleManager.cpp
@@ +362,4 @@
>    nsIDocument* doc = PresContext()->Document();
>    Element* root = doc->GetRootElement();
>    if (root) {
> +    while (!mModifiedElements.IsEmpty()) {

Probably worth a comment pointing out that frame construction can post restyles back.

Also, it seems to me that ideally that shouldn't happen, but oh well...

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c1cb8ecde7f
stylo: Handle restyles generated during change hint processing sooner. r=emilio

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4c1cb8ecde7f