1316286 - ATMO V2: Add deployment notification for New Relic to dockerflow setup

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Metrics: Pipeline, defect, P2)

Description

[Jannis Leidel [:jezdez]]

As implemented in https://github.com/mozilla/telemetry-analysis-service/blob/484f95966ab012a9f89ca4852228474f7056a442/bin/pre_deploy#L19-L36 we need the same type of deployment notification for New Relic implemented for the dockerflow setup so application errors are correctly classified in New Relic per deployment.

Comment 1

[Jannis Leidel [:jezdez]]

Blake, for this to work we need a NEW_RELIC_API_KEY set as well, so this may be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1311634#c10 in which I ask you to double check if the secrets stored in the dockerflow secret store are matching what we have in the Heroku environment.

Comment 2

[Blake Imsland [:robotblake]]

This is currently handled by jenkins as part of the deploy process, see [1] and [2].

[1] https://github.com/mozilla-services/cloudops-deployment/blob/master/projects/atmo/pipeline.groovy#L34
[2] https://github.com/mozilla-services/cloudops-deployment/blob/master/libs/pipeline/vars/recordDeployment.groovy

Comment 3

[Blake Imsland [:robotblake]]

Does that cover what you need?

Comment 4

[Jannis Leidel [:jezdez]]

:robotblake It'd be neat to have the GitHub compare URL generated as part of the changelog, the revision.txt file contains the previous revision and it could just compare to the Git tag just fine, unless you have access to the previous Git tag in Jenkins some how. Could you make that modification to the groovy files?

Comment 5

[Jannis Leidel [:jezdez]]

Forgot to needinfo you, Blake.

Comment 6

[Jannis Leidel [:jezdez]]

This seems to have been magically fixed. Thanks Blake!