1316288 - Fix some config scripts to not error if cc isn't found

Status: RESOLVED FIXED

(NSS :: Build, defect)

Description

[(not currently active) Ted Mielczarek]

werror.py and check_cc_clang.py currently fail if CC isn't set in the environment and cc doesn't exist on the path. This happens to be true in Firefox builds. We should just make them exit in this case.

I wish gyp had a way to not run these scripts when the variable already has a provided value, but it's not that clever.

Comment 1

[(not currently active) Ted Mielczarek]

Attachment: Fix werror.py and check_cc_clang.py for cases where cc doesn't exist

Comment 2

[Franziskus Kiefer [:franziskus]]

Comment on attachment 8808972 [details] [diff] [review]
Fix werror.py and check_cc_clang.py for cases where cc doesn't exist

Review of attachment 8808972 [details] [diff] [review]:
-----------------------------------------------------------------

I'd recommend setting CC instead. But that's a small change, that's fine.

Comment 3

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/projects/nss-try/rev/a729b004edd3e1e5c1a2b67a9f0d3eb16f8fcaae
bug 1316288 - Fix werror.py and check_cc_clang.py for cases where cc doesn't exist. r?franziskus

Comment 4

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/projects/nss/rev/d163d0825ac77faa77c4cdf671a665fd6600443b
bug 1316288 - Fix werror.py and check_cc_clang.py for cases where cc doesn't exist. r=franziskus