Open
Bug 1316346
Opened 9 years ago
Updated 3 years ago
Update BookmarkNode hierarchy to support a cleaner API for bookmark removal
Categories
(Firefox for iOS :: Sync, defect)
Tracking
()
NEW
| Tracking | Status | |
|---|---|---|
| fxios | + | --- |
People
(Reporter: sleroux, Unassigned)
Details
(Whiteboard: [cleanup])
The new API for removing a bookmark from a BookmarkFolder [1] requires its result to be an optional MemoryBookmarkFolder. The result of this method should actually never be an optional but the current class hierarchy constrains us to do so. We should rework the relationship between BookmarkNode/BookmarkFolder to clean up this API.
Additionally, it might be a good time to revisit using an 'abstract' base class for BookmarkFolder and investigate using a more protocol-oriented approach. A first pass for this has been done here [2]
[1] https://github.com/mozilla-mobile/firefox-ios/pull/2193
[2] https://github.com/mozilla-mobile/firefox-ios/tree/sleroux/Bug1278262-BookmarkCrashWhileSyncing-Protocolize
|
||
Updated•3 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•