Closed Bug 1316359 Opened 5 years ago Closed 5 years ago

Wrong use of contentPrincipal in autocomplete.xml

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Version:
50 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: baku, Assigned: baku)

References

(Blocks 1 open bug)

Details

(Whiteboard: [userContextId])

Attachments

(1 file, 1 obsolete file)

search2.patch
1.48 KB, patch
Gijs
: review+
Details | Diff | Splinter Review
Attached patch search2.patch (obsolete) — — Splinter Review 
No description provided.
Attachment #8809066 - Flags: review?(gijskruitbosch+bugs)
Depends on: 1244340
Comment on attachment 8809066 [details] [diff] [review]
search2.patch

Review of attachment 8809066 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: doublequotes.

Can you elaborate on the subject/summary of this bug? I... don't see how it relates to this patch (which doesn't have a commit message).
Attachment #8809066 - Flags: review?(gijskruitbosch+bugs)
Attached patch search2.patch — — Splinter Review 
When a container tab is opened and it shows an about:page, we use a systemPrincipal. This means that the originAttributes.userContextId is 0.
Instead using principal, this patch uses the attribute of the element.
Attachment #8809066 - Attachment is obsolete: true
Attachment #8809090 - Flags: review?(gijskruitbosch+bugs)
Attachment #8809090 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd3eebd3f3c
autocomplete.xml must get userContextId from the attribute of the element instead using contentPrincipal, r=Gijs
https://hg.mozilla.org/mozilla-central/rev/5cd3eebd3f3c
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Blocks: ContextualIdentity
Whiteboard: [userContextId]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.