Wrong use of contentPrincipal in autocomplete.xml

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

(Blocks 1 bug)

50 Branch
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [userContextId])

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

3 years ago
Posted patch search2.patch (obsolete) — Splinter Review
No description provided.
Attachment #8809066 - Flags: review?(gijskruitbosch+bugs)
Assignee

Updated

3 years ago
Depends on: 1244340

Comment 1

3 years ago
Comment on attachment 8809066 [details] [diff] [review]
search2.patch

Review of attachment 8809066 [details] [diff] [review]:
-----------------------------------------------------------------

Nit: doublequotes.

Can you elaborate on the subject/summary of this bug? I... don't see how it relates to this patch (which doesn't have a commit message).
Attachment #8809066 - Flags: review?(gijskruitbosch+bugs)
Assignee

Comment 2

3 years ago
Posted patch search2.patchSplinter Review
When a container tab is opened and it shows an about:page, we use a systemPrincipal. This means that the originAttributes.userContextId is 0.
Instead using principal, this patch uses the attribute of the element.
Attachment #8809066 - Attachment is obsolete: true
Attachment #8809090 - Flags: review?(gijskruitbosch+bugs)

Updated

3 years ago
Attachment #8809090 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 3

3 years ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5cd3eebd3f3c
autocomplete.xml must get userContextId from the attribute of the element instead using contentPrincipal, r=Gijs

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5cd3eebd3f3c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

3 years ago
Whiteboard: [userContextId]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.