1316367 - Suggested reviewers update for Firefox & Toolkit

Status: RESOLVED FIXED

Description

[:Gijs (he/him)]

For toolkit::everything else, please:

- remove:
 [e-mail] (not very active anymore, shouldn't suggest)
 [e-mail] (hasn't reviewed anything in Toolkit in the last 1.5 years, probably longer if you exclude the trivial patch in bug 1164876, but it's hard to search correctly)
 [e-mail] (left mozilla)
 [e-mail] (also no longer reviewing toolkit stuff)
 [e-mail] (on hiatus)
 [e-mail] (left mozilla)

- add:
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]
 [e-mail]

(from list at https://wiki.mozilla.org/Modules/Firefox and https://wiki.mozilla.org/Modules/Toolkit - I've been slightly selective and omitted other people who I don't believe are current active toolkit reviewers and/or e.g. dolske who IME prefers people he manages (like me!) to do reviewing where possible)


For Firefox's "everything else" list:

- remove: [e-mail]
- add: make the list match the above toolkit list.

If we think that's too long a list, I can try and narrow people down by component but that is going to be more work.

Comment 1

[Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me]

For Toolkit, the suggested reviewer list is now:

[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]

Comment 2

[Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me]

New list for Firefox is:

[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]
[e-mail]

Comment 3

[Justin Dolske [:Dolske]]

(In reply to :Gijs Kruitbosch from comment #0)
> [...] e.g. dolske who IME prefers people he manages (like me!) to
> do reviewing where possible)

Eh, that's not really true. I still do reviews, or redirect if needed, and it hasn't been a burden. Please add me back to both buckets.

Comment 4

[Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me]

Done!

Comment 5

[:Gijs (he/him)]

(In reply to Justin Dolske [:Dolske] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #0)
> > [...] e.g. dolske who IME prefers people he manages (like me!) to
> > do reviewing where possible)
> 
> Eh, that's not really true. I still do reviews, or redirect if needed, and
> it hasn't been a burden. Please add me back to both buckets.

Oops, sorry!

So... having looked at this, the dropdown is a bit... unwieldy... with 15-odd people in it. Apparently sorting it by number of reviews got wontfixed ( bug 951313 ). I guess it might be worth trying to split people up across components more? There wasn't really much of a split at all when I filed this. Is there some way we could use the triage people + backups to do that so I (or someone else) don't have to reinvent the wheel? Is that information easily accessible as well?

Comment 6

[Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me]

We don't have a 'backup' field. If you'd like to split this up across components in each product, please file a new ticket.

Having suggested reviewers at the product level overrides the component level reviewer lists, so we'd have to specify a set for each component, unless there's reason to change that behavior in bmo.

Comment 7

[:Gijs (he/him)]

(In reply to Emma Humphries ☕️ [:emceeaich] (UTC-8) +needinfo me from comment #6)
> Having suggested reviewers at the product level overrides the component
> level reviewer lists, so we'd have to specify a set for each component,
> unless there's reason to change that behavior in bmo.

This is odd. https://bugzilla.mozilla.org/page.cgi?id=review_suggestions.html#Firefox lists things for a few component, and then one backup "all other components" field. Can we not manipulate other individual components?

Comment 8

[Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me]

Ah, it is editable at the component level. It was pre-populating and looking like a non-editable input until I clicked and typed in it. So you can override still.