Closed
Bug 1316367
Opened 8 years ago
Closed 8 years ago
Suggested reviewers update for Firefox & Toolkit
Categories
(bugzilla.mozilla.org :: Administration, task)
Tracking
()
RESOLVED
FIXED
People
(Reporter: Gijs, Assigned: emceeaich)
References
Details
For toolkit::everything else, please: - remove: gavin.sharp@gmail.com (not very active anymore, shouldn't suggest) dietrich@mozilla.com (hasn't reviewed anything in Toolkit in the last 1.5 years, probably longer if you exclude the trivial patch in bug 1164876, but it's hard to search correctly) netzen@gmail.com (left mozilla) edilee@mozilla.com (also no longer reviewing toolkit stuff) blair@theunfocused.net (on hiatus) asaf@sent.com (left mozilla) - add: l10n@mozilla.com gfritzsche@mozilla.com bnicholson@mozilla.com ehsan@mozilla.com paolo@mozilla.com standard8@mozilla.com mdeboer@mozilla.com mconley@mozilla.com markh@mozilla.com felipc@gmail.com rhelmer@mozilla.com gijskruitbosch+bugs@gmail.com kmaglione+bmo@mozilla.com wmccloskey@mozilla.com MattN+bmo@mozilla.com florian@queze.net msamuel@mozilla.com aswan@mozilla.com jaws@mozilla.com (from list at https://wiki.mozilla.org/Modules/Firefox and https://wiki.mozilla.org/Modules/Toolkit - I've been slightly selective and omitted other people who I don't believe are current active toolkit reviewers and/or e.g. dolske who IME prefers people he manages (like me!) to do reviewing where possible) For Firefox's "everything else" list: - remove: dolske@mozilla.com - add: make the list match the above toolkit list. If we think that's too long a list, I can try and narrow people down by component but that is going to be more work.
Assignee | ||
Comment 1•8 years ago
|
||
For Toolkit, the suggested reviewer list is now: adw@mozilla.com aswan@mozilla.com benjamin@smedbergs.us bnicholson@mozilla.com dao+bmo@mozilla.com dolske@mozilla.com doug.turner@gmail.com dteller@mozilla.com dtownsend@mozilla.com ehsan@mozilla.com enndeakin@gmail.com felipc@gmail.com florian@queze.net gfritzsche@mozilla.com gijskruitbosch+bugs@gmail.com gps@mozilla.com jaws@mozilla.com jmathies@mozilla.com kmaglione+bmo@mozilla.com l10n@mozilla.com mak77@bonardo.net markh@mozilla.com MattN+bmo@mozilla.com mconley@mozilla.com mdeboer@mozilla.com msamuel@mozilla.com nfroyd@mozilla.com paolo.mozmail@amadzone.org rhelmer@mozilla.com robert.strong.bugs@gmail.com standard8@mozilla.com ted@mielczarek.org wmccloskey@mozilla.com
Assignee | ||
Comment 2•8 years ago
|
||
New list for Firefox is: aswan@mozilla.com bnicholson@mozilla.com dtownsend@mozilla.com ehsan@mozilla.com felipc@gmail.com florian@queze.net gfritzsche@mozilla.com gijskruitbosch+bugs@gmail.com jaws@mozilla.com kmaglione+bmo@mozilla.com l10n@mozilla.com mak77@bonardo.net markh@mozilla.com MattN+bmo@mozilla.com mconley@mozilla.com mdeboer@mozilla.com msamuel@mozilla.com paolo.mozmail@amadzone.org rhelmer@mozilla.com standard8@mozilla.com wmccloskey@mozilla.com
Assignee: nobody → ehumphries
Comment 3•8 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #0) > [...] e.g. dolske who IME prefers people he manages (like me!) to > do reviewing where possible) Eh, that's not really true. I still do reviews, or redirect if needed, and it hasn't been a burden. Please add me back to both buckets.
Flags: needinfo?(ehumphries)
Assignee | ||
Comment 4•8 years ago
|
||
Done!
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(ehumphries)
Resolution: --- → FIXED
Reporter | ||
Comment 5•8 years ago
|
||
(In reply to Justin Dolske [:Dolske] from comment #3) > (In reply to :Gijs Kruitbosch from comment #0) > > [...] e.g. dolske who IME prefers people he manages (like me!) to > > do reviewing where possible) > > Eh, that's not really true. I still do reviews, or redirect if needed, and > it hasn't been a burden. Please add me back to both buckets. Oops, sorry! So... having looked at this, the dropdown is a bit... unwieldy... with 15-odd people in it. Apparently sorting it by number of reviews got wontfixed ( bug 951313 ). I guess it might be worth trying to split people up across components more? There wasn't really much of a split at all when I filed this. Is there some way we could use the triage people + backups to do that so I (or someone else) don't have to reinvent the wheel? Is that information easily accessible as well?
Flags: needinfo?(ehumphries)
Assignee | ||
Comment 6•8 years ago
|
||
partly-obsolete |
We don't have a 'backup' field. If you'd like to split this up across components in each product, please file a new ticket. Having suggested reviewers at the product level overrides the component level reviewer lists, so we'd have to specify a set for each component, unless there's reason to change that behavior in bmo.
Flags: needinfo?(ehumphries)
Reporter | ||
Comment 7•8 years ago
|
||
(In reply to Emma Humphries ☕️ [:emceeaich] (UTC-8) +needinfo me from comment #6) > Having suggested reviewers at the product level overrides the component > level reviewer lists, so we'd have to specify a set for each component, > unless there's reason to change that behavior in bmo. This is odd. https://bugzilla.mozilla.org/page.cgi?id=review_suggestions.html#Firefox lists things for a few component, and then one backup "all other components" field. Can we not manipulate other individual components?
Flags: needinfo?(ehumphries)
Assignee | ||
Comment 8•8 years ago
|
||
Ah, it is editable at the component level. It was pre-populating and looking like a non-editable input until I clicked and typed in it. So you can override still.
Flags: needinfo?(ehumphries)
You need to log in
before you can comment on or make changes to this bug.
Description
•