13164 - Open does not work in the editor

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Sammy Ford]

Using a pull from Saturday i was not able to get open to work until i commented
out line 1247 of nsEditorShell.cpp to if ( /* parent|| */ !(htmlFilter ||
imgFilter))

the error was:
JavaScript error: uncaught exception: [Exception... "Component returned failure
code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIEditorShell.Open]"  nsresult:
"0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame
:chrome://editor/content/EditorCommands.js :: EditorOpen :: line 224"  data:
no]

I am using Mandrake 6, it has also been tested on Mac by sfraser.

Comment 1

[Simon Fraser [no longer active]]

Charlie: this appears to be related to the text for a null parent for the file
widget that you changed recently.

Comment 2

[Kathleen :Brade]

Choose Image button is also broken (image dialog)

Comment 3

[Charles Manske]

Oops! I thought the bug relating to the parent window was fixed and started
down the path of adjusting for it, but the bug wasn't fixed and I missed
reverting to not testing parent window.

Comment 4

[Charles Manske]

checked in 9/7/99. The test for a null parent was removed so we can use Open,
but should be activated when bug 6783 is fixed.

Comment 5

[sujay]

tested both File Open and Open button from toolbar...both seem to
work in 9/9 build...