Closed Bug 1316408 Opened 9 years ago Closed 9 years ago

Remove all b2g related code from testing/xpcshell

Categories

(Testing :: XPCShell Harness, defect)

defect
Not set
normal

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: ahal, Assigned: ahal)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We should simplify the xpcshell harness by removing b2g related code.
Comment on attachment 8809128 [details] Bug 1316408 - Remove all b2g related code from testing/xpcshell, https://reviewboard.mozilla.org/r/91778/#review91680 ::: testing/xpcshell/mach_commands.py (Diff revision 1) > > + > @CommandProvider > class MachCommands(MachCommandBase): > - def __init__(self, context): > - MachCommandBase.__init__(self, context) do we still need the __init__?
Attachment #8809128 - Flags: review?(jmaher) → review+
Comment on attachment 8809128 [details] Bug 1316408 - Remove all b2g related code from testing/xpcshell, https://reviewboard.mozilla.org/r/91778/#review91680 > do we still need the __init__? No, those attributes were only set by the b2g mach environment. The parent class' __init__ will be enough.
Pushed by ahalberstadt@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d2192fd7bf45 Remove all b2g related code from testing/xpcshell, r=jmaher
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
No longer blocks: 1369194
See Also: → 1635563
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: