1316484 - Add empty line between "use strict"; and linter comment and the license header

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

Every files should always be an empty line between "use strict"; and linter comment and the Mozilla license header.

Code style for every file in netmonitor should look like:

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

/* globals NetMonitorView */

"use strict";

const xxx = ...

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1316484 - Add empty line for all netmonitor files

Review commit: https://reviewboard.mozilla.org/r/93056/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93056/

Comment 2

[Ricky Chien [:rickychien] (inactive)]

There are two bugs which are bug 1309194 and bug 1309496 in checkin-needed progress, so I'll rebase and update my patch once both of them are landed.

I also remove the vim setting at the top 

/* vim: set ft=javascript ts=2 et sw=2 tw=80: */

from files since I think it's out-of-date and we can't assure everyone uses vim as their default editor.

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8810740 [details]
Bug 1316484 - Add empty line for all netmonitor files

https://reviewboard.mozilla.org/r/93056/#review93060

Looks good to me and I like the consistency!

R+, but note that there is apparently no team-wide consensus whether the
vim comments should be inserted in every file or removed from every file.
In any case I support what you did.

Thanks,
Honza

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8810740 [details]
Bug 1316484 - Add empty line for all netmonitor files

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93056/diff/1-2/

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Autoland couldn't rebase this for landing.

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8810740 [details]
Bug 1316484 - Add empty line for all netmonitor files

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93056/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df32da99c23c
Add empty line for all netmonitor files r=Honza

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/df32da99c23c

Comment 9

[areya]

https://hg.mozilla.org/mozilla-central/rev/df32da99c23c