1316511 - Remove friend class nsSVGPathFrame declaration in SVGPathElement

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[u459114]

http://searchfox.org/mozilla-central/source/dom/svg/SVGPathElement.h#30
Since nsSVGPathFrame is not existed anymore.

Comment 1

[Ajit]

I am interested in fixing this bug. I am stuck at the first step itself (that is to assign the bug to me). I would grateful if you could help me with that. I have followed the steps to setup a build environment and completed my first build. I would also need your guidance in steps to be taken to make the necessary changes.

Comment 2

[u459114]

There is a "take" hyperlink at right hand side of "Assigned To" label. Click on it then you will take this bug. Or, you can also click on "edit" and manually write down your email address, which is "[e-mail]"

The next step is working on the patch and ask for review. Here is a guideline - 
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Let me know if you have any problem on that.

Comment 3

[Ajit]

(In reply to C.J. Ku[:cjku](UTC+8) from comment #2)
> There is a "take" hyperlink at right hand side of "Assigned To" label. Click
> on it then you will take this bug. Or, you can also click on "edit" and
> manually write down your email address, which is "[e-mail]"
> 
> The next step is working on the patch and ask for review. Here is a
> guideline - 
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> How_to_Submit_a_Patch
> 
> Let me know if you have any problem on that.

I can't seem to see the link anywere near the label. I created my account today. Could it be some permission issue on the account?? I am attaching the screenshots of what I can see. http://imgur.com/a/3wF0Y. When I click on only hyperlink next to assigned to label this is what I see. http://imgur.com/a/eG9uF. The three different options don't have any options to assign the bug to myself.

Comment 4

[Rishi Ahya]

Hi Cku I have added my email address to this bug, and was hoping you could guide me into how to fix this bug

Comment 5

[u459114]

(In reply to Ajit from comment #3)
> (In reply to C.J. Ku[:cjku](UTC+8) from comment #2)
> > There is a "take" hyperlink at right hand side of "Assigned To" label. Click
> > on it then you will take this bug. Or, you can also click on "edit" and
> > manually write down your email address, which is "[e-mail]"
> > 
> > The next step is working on the patch and ask for review. Here is a
> > guideline - 
> > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> > How_to_Submit_a_Patch
> > 
> > Let me know if you have any problem on that.
> 
> I can't seem to see the link anywere near the label. I created my account
> today. Could it be some permission issue on the account?? I am attaching the
> screenshots of what I can see. http://imgur.com/a/3wF0Y. When I click on
> only hyperlink next to assigned to label this is what I see.
> http://imgur.com/a/eG9uF. The three different options don't have any options
> to assign the bug to myself.
Let's not be blocked here. Assigned to you already. You may move forward.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

I think this bug is simply removed the two lines in http://searchfox.org/mozilla-central/source/dom/svg/SVGPathElement.h#30-31

Comment 7

[Ajit]

(In reply to Ting-Yu Lin [:TYLin] (UTC+8) from comment #6)
> I think this bug is simply removed the two lines in
> http://searchfox.org/mozilla-central/source/dom/svg/SVGPathElement.h#30-31

Yes I agree. I am in process of patching them. Trying to get the patch working on my system.

Comment 8

[Ajit]

Attachment: Bug 1316511 - Remove friend class nsSVGPathFrame declaration in SVGPathElement as it does not exist anymore

Review commit: https://reviewboard.mozilla.org/r/93552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93552/

Comment 9

[(no longer active)]

Comment on attachment 8811470 [details]
Bug 1316511 - Remove friend class nsSVGPathFrame declaration in SVGPathElement as it does not exist anymore

https://reviewboard.mozilla.org/r/93552/#review93864

Thank you for the patch!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01c0a8ec64f9
Remove friend class nsSVGPathFrame declaration in SVGPathElement as it does not exist anymore r=Ehsan

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/01c0a8ec64f9

Comment 12

[u459114]

Well done

Comment 13

[Ajit]

(In reply to C.J. Ku[:cjku](UTC+8) from comment #12)
> Well done

Thanks for all the help. I am glad to have fixed my first bug. I know this is off topic. Could you please point me to any resources to setup debugging for firefox on Visual Studio 2015 and Windows 64bit OS. I expect other bugs to require proper debugging. If it is not possible to setup on vs 2015 please let me know on how you normally debug. I hope I haven't troubled you much in submitting my first bug :-) Once again thanks for being my mentor.

Comment 14

[areya]

https://hg.mozilla.org/mozilla-central/rev/01c0a8ec64f9

Comment 15

[u459114]

(In reply to Ajit from comment #13)
> (In reply to C.J. Ku[:cjku](UTC+8) from comment #12)
> > Well done
> 
> Thanks for all the help. I am glad to have fixed my first bug. I know this
> is off topic. Could you please point me to any resources to setup debugging
> for firefox on Visual Studio 2015 and Windows 64bit OS. I expect other bugs
> to require proper debugging. If it is not possible to setup on vs 2015
> please let me know on how you normally debug. I hope I haven't troubled you
> much in submitting my first bug :-) Once again thanks for being my mentor.
I learned how to setup Visual Studio 2015 from here:
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Windows_Prerequisites
Hope it's useful to you.