1316530 - Pass WebGL2 conformance deqp/functional/gles3/framebufferblit

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Ethan Lin[:ethlin]]

We have these failures:
    failed: blit.conversion.rgba8_to_rgba32f: glError: INVALID_OPERATION
    failed: blit.conversion.rgba8_to_rgba16f: glError: INVALID_OPERATION
    failed: blit.conversion.rgba8_to_r11f_g11f_b10f: glError: INVALID_OPERATION
    failed: blit.conversion.rgba8_to_rg32f: glError: INVALID_OPERATION
    failed: blit.conversion.rgba8_to_rg16f: glError: INVALID_OPERATION
    failed: blit.conversion.rgba8_to_r32f: glError: INVALID_OPERATION
    failed: blit.conversion.rgba8_to_r16f: glError: INVALID_OPERATION

Comment 1

[Ethan Lin[:ethlin]]

https://www.khronos.org/opengles/sdk/docs/man3/html/glBlitFramebuffer.xhtml says:
GL_INVALID_OPERATION is generated if mask contains GL_COLOR_BUFFER_BIT and any of the following conditions hold:
    The read buffer contains fixed-point or floating-point values and any draw buffer contains neither fixed-point nor floating-point values.
    The read buffer contains unsigned integer values and any draw buffer does not contain unsigned integer values.
    The read buffer contains signed integer values and any draw buffer does not contain signed integer values.

It looks like we should return INVALID_OPERATION when detecting integer to float.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1316530 - Normalized int/uint count as fixed, and should be treated like floats in BlitFramebuffer. -

Review commit: https://reviewboard.mozilla.org/r/92982/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92982/

Comment 3

[Ethan Lin[:ethlin]]

Comment on attachment 8810696 [details]
Bug 1316530 - Normalized int/uint count as fixed, and should be treated like floats in BlitFramebuffer. -

https://reviewboard.mozilla.org/r/92982/#review92932

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/510d3ebfd1f6
Normalized int/uint count as fixed, and should be treated like floats in BlitFramebuffer. - r=ethlin

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/510d3ebfd1f6

Comment 6

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8810696 [details]
Bug 1316530 - Normalized int/uint count as fixed, and should be treated like floats in BlitFramebuffer. -

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]:
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: 
[String/UUID change made/needed]:

Comment 7

[Gerry Chang [:gchang]]

Comment on attachment 8810696 [details]
Bug 1316530 - Normalized int/uint count as fixed, and should be treated like floats in BlitFramebuffer. -

Fix WebGL 2 issue. Beta51+ and Aurora52+. Should be in 51 beta 3.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7a0a906b9680

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d2a50c565d37