Add a bug number field to a histogram entry "COOKIE_LEAVE_SECURE_ALONE" .

RESOLVED FIXED in Firefox 52

Status

()

Core
Networking: Cookies
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Amy, Assigned: Amy)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

(Whiteboard: [necko-active])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

a year ago
Add a bug number field to a histogram entry "COOKIE_LEAVE_SECURE_ALONE", and remove "COOKIE_LEAVE_SECURE_ALONE" from histogram-whitelists.json.
(Assignee)

Updated

a year ago
Assignee: nobody → amchung
Blocks: 976073
(Assignee)

Comment 1

a year ago
Created attachment 8809344 [details] [diff] [review]
added a bug number on "COOKIE_LEAVE_SECURE_ALONE" entry.

Hi Francois,
I added a telemetry for sepc https://datatracker.ietf.org/doc/draft-ietf-httpbis-cookie-alone/ on bug 976073.
I modified code from the suggestions https://bugzilla.mozilla.org/show_bug.cgi?id=976073#c99 as below:
1. added a bug-number on "COOKIE_LEAVE_SECURE_ALONE" entry 
2. removed "COOKIE_LEAVE_SECURE_ALONE" from whitelist.

Please help me to review my patch, thanks!
Attachment #8809344 - Flags: review?(francois)
(Assignee)

Updated

a year ago
Target Milestone: --- → mozilla52
Comment on attachment 8809344 [details] [diff] [review]
added a bug number on "COOKIE_LEAVE_SECURE_ALONE" entry.

Review of attachment 8809344 [details] [diff] [review]:
-----------------------------------------------------------------

datareview+ but please update the email address too.

::: toolkit/components/telemetry/Histograms.json
@@ +7889,5 @@
>      "releaseChannelCollection": "opt-out",
>      "description": "How often are secure cookies set from non-secure origins, and vice-versa? 0=nonsecure/http, 1=nonsecure/https, 2=secure/http, 3=secure/https"
>    },
>    "COOKIE_LEAVE_SECURE_ALONE": {
>      "alert_emails": ["seceng@mozilla.org"],

Could you also please change this to seceng-telemetry@mozilla.com ?
Attachment #8809344 - Flags: review?(francois) → review+
(Assignee)

Comment 3

a year ago
Created attachment 8809553 [details] [diff] [review]
added a bug number on "COOKIE_LEAVE_SECURE_ALONE" entry.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cd9583dcbd6c97623d6d05bab59feda9378f48c&selectedJob=30825506
Attachment #8809344 - Attachment is obsolete: true
Attachment #8809553 - Flags: review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed
Whiteboard: [necko-active]

Comment 4

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca77916dbaef
Add a bug number to the 'COOKIE_LEAVE_SECURE_ALONE' histogram entry. r=francois
Keywords: checkin-needed

Comment 5

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/ca77916dbaef
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.