1316542 - Add a bug number field to a histogram entry "COOKIE_LEAVE_SECURE_ALONE" .

Status: RESOLVED FIXED

(Core :: Networking: Cookies, defect)

Description

[Amy Chung [:Amy]]

Add a bug number field to a histogram entry "COOKIE_LEAVE_SECURE_ALONE", and remove "COOKIE_LEAVE_SECURE_ALONE" from histogram-whitelists.json.

Comment 1

[Amy Chung [:Amy]]

Attachment: added a bug number on "COOKIE_LEAVE_SECURE_ALONE" entry.

Hi Francois,
I added a telemetry for sepc https://datatracker.ietf.org/doc/draft-ietf-httpbis-cookie-alone/ on bug 976073.
I modified code from the suggestions https://bugzilla.mozilla.org/show_bug.cgi?id=976073#c99 as below:
1. added a bug-number on "COOKIE_LEAVE_SECURE_ALONE" entry 
2. removed "COOKIE_LEAVE_SECURE_ALONE" from whitelist.

Please help me to review my patch, thanks!

Comment 2

[François Marier [:francois]]

Comment on attachment 8809344 [details] [diff] [review]
added a bug number on "COOKIE_LEAVE_SECURE_ALONE" entry.

Review of attachment 8809344 [details] [diff] [review]:
-----------------------------------------------------------------

datareview+ but please update the email address too.

::: toolkit/components/telemetry/Histograms.json
@@ +7889,5 @@
>      "releaseChannelCollection": "opt-out",
>      "description": "How often are secure cookies set from non-secure origins, and vice-versa? 0=nonsecure/http, 1=nonsecure/https, 2=secure/http, 3=secure/https"
>    },
>    "COOKIE_LEAVE_SECURE_ALONE": {
>      "alert_emails": ["[e-mail]"],

Could you also please change this to [e-mail] ?

Comment 3

[Amy Chung [:Amy]]

Attachment: added a bug number on "COOKIE_LEAVE_SECURE_ALONE" entry.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9cd9583dcbd6c97623d6d05bab59feda9378f48c&selectedJob=30825506

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca77916dbaef
Add a bug number to the 'COOKIE_LEAVE_SECURE_ALONE' histogram entry. r=francois

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ca77916dbaef