1316690 - Crash in gfxPlatform::Init in GPU process

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Andrew McCreight [:mccr8]]

This bug was filed from the Socorro interface and is 
report bp-3d442b90-b9d9-4025-8a46-9a7d52161109.
=============================================================

There are about a half dozen of these crashes a day on Nightly. At least for the 11-8 build, they are all in the GPU process, so there might be something to improve here.

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

It looks like there's a bunch of device reset code in TextureD3D11.cpp. Not sure exactly how much of this is needed anymore, but let's give it the benefit of the doubt and migrate reset code handling to DeviceManagerDx.

Comment 2

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 1, move to DeviceManagerDx

This moves all the DeviceResetReason state from gfxWindowsPlatform to DeviceManagerDx. Mostly code motion, but some small details changed:

(1) mHasDeviceReset/mDeviceResetReason were folded into a Maybe<>
(2) mHasD3D9DeviceReset was folded into DeviceResetReason
(3) Everything now happens in the device lock
(4) Test device resets now only work on the main thread (and still only in the GPU process), since that's the only place where it's valid to set gfxPrefs.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 2, fix TextureD3D11

This fixes TextureD3D11 so it no longer uses gfxWindowsPlatform.

Comment 4

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: part 3, update GPU process path

This updates MaybeResetAndReacquireDevices for the changes in part 1.

Comment 5

[Ryan Hunt [:rhunt]]

Really happy that this code is being moved out of gfxWindowsPlatform.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b76383a5182
Move device reset detection from gfxPlatform to DeviceManagerDx. (bug 1316690 part 1, r=rhunt)
https://hg.mozilla.org/integration/mozilla-inbound/rev/86e2aea8417c
Don't use gfxWindowsPlatform in TextureD3D11. (bug 1316690 part 2, r=rhunt)
https://hg.mozilla.org/integration/mozilla-inbound/rev/353ef7001763
Handle forced device resets in the GPU process. (bug 1316690 part 3, r=rhunt)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1b76383a5182
https://hg.mozilla.org/mozilla-central/rev/86e2aea8417c
https://hg.mozilla.org/mozilla-central/rev/353ef7001763