1316748 - Move WebExtension Port messaging off MessageChannel

Status: RESOLVED FIXED

(WebExtensions :: General, defect, P1)

Description

[Andrew Swan [:aswan]]

Follow-up from https://bugzilla.mozilla.org/show_bug.cgi?id=1313980#c21
Kris may want to expand on this but I think it makes sense to continue to use MessageChannel for setting up and tearing down Ports but to use message managers directly for postMessage, avoiding the extra filtering/routing in MessageChannel.

Comment 1

[Shane Caraveo (:mixedpuppy)]

still relevant?

Comment 2

[Andrew Swan [:aswan]]

Probably not, I understand Kris has plans in this area but I don't know what they are.

Comment 3

[Tomislav Jovanovic :zombie]

Some of the linked comments are probably relevant for the coming rewrite related to fission, marking as blocking to remember to look into it later.

Comment 4

[Tomislav Jovanovic :zombie]

This should in theory be least dependent on bug 1580448, as the perf impact of sending individual messages to listeners in multiple iframes (instead of broadcasting via MessageManagers) will be localized only to the connect call, while most individual port messages are going to be 1:1 in the common case.

Comment 5

[Tomislav Jovanovic :zombie]

Attachment: Bug 1583484 - Move Port messaging off MessageChannel

Comment 6

[Tomislav Jovanovic :zombie]

Attachment: Bug 1316748 - Move Port messaging off MessageChannel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/601e0a6a8ee9
Move Port messaging off MessageChannel r=mixedpuppy

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/601e0a6a8ee9