Closed
Bug 1316762
Opened 8 years ago
Closed 8 years ago
Add fuzzy annotation for box-sizing-replaced-003.xht on linux
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: dholbert, Unassigned)
References
Details
Attachments
(1 file)
Filing this bug on annotating box-sizing-replaced-003.xht as fuzzy on linux, since it becomes fuzzy there when we reduce the paint delay (bug 1283302). Failures look like: { REFTEST TEST-UNEXPECTED-FAIL | [...]/box-sizing-replaced-003-ref.xht | image comparison, max difference: 14, number of differing pixels: 43 } https://treeherder.mozilla.org/logviewer.html#?job_id=39017948&repo=mozilla-inbound#L27106 The reftest snapshot shows that it's just a few fuzzy pixels at the edge of a shape in a scaled image. Not a particularly unexpected sort of artifact, when image scaling is going on. And it looks like we hit this elsewhere (and annotated this exact test as fuzzy on Android) in bug 1128229. So, we should be fine to annotate it as fuzzy on Linux as well. We might need an across-the-board fuzzy annotation, but let's start conservatively.
Reporter | ||
Comment 1•8 years ago
|
||
(I'm not filing this as an intermittent bug, because we already have one for this test -- bug 1146002. I don't think the failure mode here is quite the same as that one, but I also don't think we gain much from having multiple intermittent bugs open for the same test, or for landing this targeted fuzzy annotation on the more-severe bug 1146002.)
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•8 years ago
|
||
(I think the existing comment on the reftest.list line here -- which points to bug 1128229 -- is sufficient to explain the fuzzy annotation, too -- that's why I didn't add a new bug link there. That bug (bug 1128229) is about fuzziness due to "failure to call imgFrame::Optimize before the reftest snapshot is taken", and I expect that's what's causing the image-scaling-fuzziness here, too.)
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8809646 [details] Bug 1316762: Add fuzzy annotation for box-sizing-replaced-003.xht on linux. https://reviewboard.mozilla.org/r/92188/#review92172
Attachment #8809646 -
Flags: review?(npancholi) → review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fec4c0269a82 Add fuzzy annotation for box-sizing-replaced-003.xht on linux. r=neerja
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/fec4c0269a82
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•