Open Bug 1316772 Opened 8 years ago Updated 2 years ago

box-sizing-replaced-001.xht and box-sizing-replaced-002.xht are missing part of a scaled image, if reftest snapshot fires before first paint

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

People

(Reporter: neerja, Unassigned)

References

Details

      No description provided.
Summary: Find and fix the underlying cause for intermittent failure in Bug 1295466 and revert the patch here that uses MozReftestInvalidate event to temporarily hide this intermittent failure. → box-sizing-replaced-001.xht is missing 1/3 of a scaled image, if reftest snapshot fires before first paint
Blocks: 1295466
As part of this bug, we also need to revert the patch landed in Bug 1295466 that uses MozReftestInvalidate event to stop the test-failure from showing up when reducing paint delay.
Update: we rolled back the change described in Comment 1 and we instead added an extremely-permissive "fuzzy" annotation, here:
  https://hg.mozilla.org/integration/autoland/rev/c46aadcf745c#l2.12

So now, when this bug is fixed, we'll want to make the following changes on top of the patches that landed in bug 1295466 comment 46:
 (1) Remove that ^^ fuzzy annotation when this bug is fixed
 (2) Backout https://hg.mozilla.org/integration/autoland/rev/faa9981549a6 (i.e. remove the duplicate files that we created there, since they only exist to allow us to run a version of this test with a Mozilla-specific "MozReftestInvalidate" hackaround)
I think the test failures in bug 1295466 are caused by this same underlying issue, too.  (At least, the failure snapshots look similar, with the right chunk of a scaled image missing. E.g. in https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=75524537&lineNumber=30184 )
Summary: box-sizing-replaced-001.xht is missing 1/3 of a scaled image, if reftest snapshot fires before first paint → box-sizing-replaced-001.xht and box-sizing-replaced-002.xht are missing part of a scaled image, if reftest snapshot fires before first paint
Priority: -- → P3

We can probably fix this now (adjusting the original test) using a double-rAF as in waitForAtLeastOneFrame() here:
https://github.com/web-platform-tests/wpt/blob/master/common/rendering-utils.js

Then we should be able to update the test annotation to expect box-sizing-replaced-001.xht and box-sizing-replaced-002.xht to expect them to pass; and then we can get rid of 1313772.xhtml per https://searchfox.org/mozilla-central/rev/ed5c7b4262d4e30656886a45321cbbf4200de349/layout/reftests/bugs/1313772.xhtml#142-143

Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.