Wrong filename in check_spidermonkey_style.py error message

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: arai, Assigned: bharatraghunthan9767)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
check_spidermonkey_style.py
https://dxr.mozilla.org/mozilla-central/rev/fc104971a4db41e38808e6412bc32e1900172f14/config/check_spidermonkey_style.py#289-290>     difflines = difflib.unified_diff(expected_output, actual_output,
>                                      fromfile='check_spider_monkey_style.py expected output',
>                                        tofile='check_spider_monkey_style.py actual output')


it says check_spider_monkey_style.py, but the filename is check_spidermonkey_style.py.
Comment hidden (mozreview-request)
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8845394 [details]
Bug 1317099 - Fix filename in check_spidermonkey_style.py error message

https://reviewboard.mozilla.org/r/118596/#review120488

Great, thank you :D
Attachment #8845394 - Flags: review?(arai.unmht) → review+
(Assignee)

Comment 3

2 years ago
Can I be assigned this bug now?
Flags: needinfo?(arai.unmht)
(Reporter)

Comment 4

2 years ago
sure.
Assignee: nobody → bharatraghunthan9767
Status: NEW → ASSIGNED
Flags: needinfo?(arai.unmht)
(Assignee)

Comment 5

2 years ago
Should anything more be done about this bug or should I just wait for it to land/autoland?
Flags: needinfo?(arai.unmht)

Comment 6

2 years ago
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/9fc1c53228b4
Fix filename in check_spidermonkey_style.py error message r=arai
(Reporter)

Comment 7

2 years ago
Thanks for the heads up :)
Flags: needinfo?(arai.unmht)

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9fc1c53228b4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
(Assignee)

Comment 9

2 years ago
So there is nothing more to be done right?
Thanks, :arai <arai.unmht@gmail.com>
(Reporter)

Comment 10

2 years ago
yes, thank you again :)
status-firefox52: affected → ---
You need to log in before you can comment on or make changes to this bug.