Closed Bug 1317099 Opened 4 years ago Closed 4 years ago

Wrong filename in check_spidermonkey_style.py error message

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: arai, Assigned: bharatraghunthan9767)

Details

Attachments

(1 file)

check_spidermonkey_style.py
https://dxr.mozilla.org/mozilla-central/rev/fc104971a4db41e38808e6412bc32e1900172f14/config/check_spidermonkey_style.py#289-290>     difflines = difflib.unified_diff(expected_output, actual_output,
>                                      fromfile='check_spider_monkey_style.py expected output',
>                                        tofile='check_spider_monkey_style.py actual output')


it says check_spider_monkey_style.py, but the filename is check_spidermonkey_style.py.
Comment on attachment 8845394 [details]
Bug 1317099 - Fix filename in check_spidermonkey_style.py error message

https://reviewboard.mozilla.org/r/118596/#review120488

Great, thank you :D
Attachment #8845394 - Flags: review?(arai.unmht) → review+
Can I be assigned this bug now?
Flags: needinfo?(arai.unmht)
sure.
Assignee: nobody → bharatraghunthan9767
Status: NEW → ASSIGNED
Flags: needinfo?(arai.unmht)
Should anything more be done about this bug or should I just wait for it to land/autoland?
Flags: needinfo?(arai.unmht)
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/9fc1c53228b4
Fix filename in check_spidermonkey_style.py error message r=arai
Thanks for the heads up :)
Flags: needinfo?(arai.unmht)
https://hg.mozilla.org/mozilla-central/rev/9fc1c53228b4
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
So there is nothing more to be done right?
Thanks, :arai <arai.unmht@gmail.com>
yes, thank you again :)
You need to log in before you can comment on or make changes to this bug.