Closed Bug 1317110 Opened 3 years ago Closed 3 years ago

Remove QuickTime plugin quirk handling

Categories

(Core :: Plug-ins, defect, P3)

Unspecified
All
defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

This patch removes special-case code to scan for the QuickTime plugin and some quirks. After we drop support for plugins other than Flash in 53, we can remove workarounds for other plugins like QuickTime.
Attachment #8810158 - Flags: review?(jmathies)
Priority: -- → P3
Attachment #8810158 - Flags: review?(jmathies) → review+
Comment on attachment 8810158 [details] [diff] [review]
remove-QuickTime-quirks.patch

Review of attachment 8810158 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginInstanceChild.cpp
@@ +1358,5 @@
>        case NPWindowTypeWindow:
>        {
>            // This check is now done in PluginInstanceParent before this call, so
>            // we should never see it here.
> +          MOZ_ASSERT(aWindow.width != 0 || aWindow.height != 0);

I think this rewrite is wrong. "!(GetQuirks() & QUIRK_QUICKTIME_AVOID_SETWINDOW)" will always be true unless the plug-in is QuickTime, so the entire assertion should be removed here.
Also, "plugin.scan.Quicktime" should be removed from all.js.
(In reply to Masatoshi Kimura [:emk] from comment #1)
> >            // This check is now done in PluginInstanceParent before this call, so
> >            // we should never see it here.
> > +          MOZ_ASSERT(aWindow.width != 0 || aWindow.height != 0);
> 
> I think this rewrite is wrong. "!(GetQuirks() &
> QUIRK_QUICKTIME_AVOID_SETWINDOW)" will always be true unless the plug-in is
> QuickTime, so the entire assertion should be removed here.

Thanks, Masatoshi. You're correct. I'll remove this assertion and the comment above it (and the "plugin.scan.Quicktime" pref in all.js).
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6abf12a9d408
Remove QuickTime plugin quirks handling. r=jimm
https://hg.mozilla.org/mozilla-central/rev/6abf12a9d408
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.