1317110 - Remove QuickTime plugin quirk handling

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: remove-QuickTime-quirks.patch

This patch removes special-case code to scan for the QuickTime plugin and some quirks. After we drop support for plugins other than Flash in 53, we can remove workarounds for other plugins like QuickTime.

Comment 1

[Masatoshi Kimura [:emk]]

Comment on attachment 8810158 [details] [diff] [review]
remove-QuickTime-quirks.patch

Review of attachment 8810158 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginInstanceChild.cpp
@@ +1358,5 @@
>        case NPWindowTypeWindow:
>        {
>            // This check is now done in PluginInstanceParent before this call, so
>            // we should never see it here.
> +          MOZ_ASSERT(aWindow.width != 0 || aWindow.height != 0);

I think this rewrite is wrong. "!(GetQuirks() & QUIRK_QUICKTIME_AVOID_SETWINDOW)" will always be true unless the plug-in is QuickTime, so the entire assertion should be removed here.

Comment 2

[Masatoshi Kimura [:emk]]

Also, "plugin.scan.Quicktime" should be removed from all.js.

Comment 3

[Chris Peterson [:cpeterson]]

(In reply to Masatoshi Kimura [:emk] from comment #1)
> >            // This check is now done in PluginInstanceParent before this call, so
> >            // we should never see it here.
> > +          MOZ_ASSERT(aWindow.width != 0 || aWindow.height != 0);
> 
> I think this rewrite is wrong. "!(GetQuirks() &
> QUIRK_QUICKTIME_AVOID_SETWINDOW)" will always be true unless the plug-in is
> QuickTime, so the entire assertion should be removed here.

Thanks, Masatoshi. You're correct. I'll remove this assertion and the comment above it (and the "plugin.scan.Quicktime" pref in all.js).

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6abf12a9d408
Remove QuickTime plugin quirks handling. r=jimm

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6abf12a9d408