Closed Bug 1317111 Opened 3 years ago Closed 3 years ago

Remove RealPlayer plugin quirk handling

Categories

(Core :: Plug-ins, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

Details

Attachments

(1 file)

After we drop support for plugins other than Flash in 53, we can remove workarounds for other plugins like RealPlayer.

This patch removes special-case code for some RealPlayer quirks. Delayed stop was only used for RealPlayer and forced reentry was only used by delayed stop (nsStopPluginRunnable).

Mats, you added these RealPlayer workarounds for bug 420886 and bug 426852 way back in 2008! :)
Attachment #8810159 - Flags: review?(mats)
Comment on attachment 8810159 [details] [diff] [review]
remove-RealPlayer-quirks.patch

>   // DoStopPlugin can process events -- There may be pending
>   // CheckPluginStopEvent events which can drop in underneath us and destroy the
>   // instance we are about to destroy. We prevent that with the mPluginStopping
>   // flag.  (aForcedReentry is only true from the callback of an earlier delayed
>   // stop)
>-  if (mIsStopping && !aForcedReentry) {
>+  if (mIsStopping) {

Please remove the last sentence in the comment.
Also, mPluginStopping should be mIsStopping, right?

r=mats
Attachment #8810159 - Flags: review?(mats) → review+
(In reply to Mats Palmgren (:mats) from comment #1)
> Please remove the last sentence in the comment.
> Also, mPluginStopping should be mIsStopping, right?

Yes. mIsStopping is the new name for mPluginStopping. I'll fix these comments.
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af3eb6a8e0ae
Remove RealPlayer plugin quirk handling. r=mats
sorry had to back this out since we had merge conflicts with 

warning: conflicts while merging dom/base/nsObjectLoadingContent.cpp! (edit, then use 'hg resolve --mark')
 on merging m-i to m-c and to unblock this merge i had to back this out
Flags: needinfo?(cpeterson)
Sorry about that. My changes on mozilla-inbound conflicted with changes (bug 1317241) that landed in the autoland repo.
Flags: needinfo?(cpeterson)
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1ad7c0aadfb
Remove RealPlayer plugin quirk handling. r=mats
https://hg.mozilla.org/mozilla-central/rev/b1ad7c0aadfb
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.