1317111 - Remove RealPlayer plugin quirk handling

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Chris Peterson [:cpeterson]]

Attachment: remove-RealPlayer-quirks.patch

After we drop support for plugins other than Flash in 53, we can remove workarounds for other plugins like RealPlayer.

This patch removes special-case code for some RealPlayer quirks. Delayed stop was only used for RealPlayer and forced reentry was only used by delayed stop (nsStopPluginRunnable).

Mats, you added these RealPlayer workarounds for bug 420886 and bug 426852 way back in 2008! :)

Comment 1

[Mats Palmgren (inactive)]

Comment on attachment 8810159 [details] [diff] [review]
remove-RealPlayer-quirks.patch

>   // DoStopPlugin can process events -- There may be pending
>   // CheckPluginStopEvent events which can drop in underneath us and destroy the
>   // instance we are about to destroy. We prevent that with the mPluginStopping
>   // flag.  (aForcedReentry is only true from the callback of an earlier delayed
>   // stop)
>-  if (mIsStopping && !aForcedReentry) {
>+  if (mIsStopping) {

Please remove the last sentence in the comment.
Also, mPluginStopping should be mIsStopping, right?

r=mats

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Mats Palmgren (:mats) from comment #1)
> Please remove the last sentence in the comment.
> Also, mPluginStopping should be mIsStopping, right?

Yes. mIsStopping is the new name for mPluginStopping. I'll fix these comments.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af3eb6a8e0ae
Remove RealPlayer plugin quirk handling. r=mats

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out since we had merge conflicts with 

warning: conflicts while merging dom/base/nsObjectLoadingContent.cpp! (edit, then use 'hg resolve --mark')
 on merging m-i to m-c and to unblock this merge i had to back this out

Comment 5

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b23408de27e4
Backed out changeset af3eb6a8e0ae

Comment 6

[Chris Peterson [:cpeterson]]

Sorry about that. My changes on mozilla-inbound conflicted with changes (bug 1317241) that landed in the autoland repo.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b1ad7c0aadfb
Remove RealPlayer plugin quirk handling. r=mats

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b1ad7c0aadfb