Closed Bug 1317154 Opened 8 years ago Closed 8 years ago

Intermittent browser_ext_windows_create_tabId.js | Test timed out -

Categories

(WebExtensions :: Untriaged, defect)

Product:
WebExtensions
Component:
Untriaged
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox51 unaffected, firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: aryx, Assigned: kmag)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Bug 1317154: Correctly support multiple concurrent listeners for the same event.
58 bytes, text/x-review-board-request
aswan
: review+
jcristau
: approval-mozilla-aurora+
Details 
https://treeherder.mozilla.org/logviewer.html#?job_id=39122046&repo=mozilla-inbound

[task 2016-11-12T23:26:03.960179Z] 23:26:03     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Promise rejected, expecting rejection to match /`incognito` property must match the incognito state of tab/, got "`incognito` property must match the incognito state of tab": Create call failed as expected - 
[task 2016-11-12T23:26:03.962141Z] 23:26:03     INFO - Try to create a window with an invalid tabId
[task 2016-11-12T23:26:03.965943Z] 23:26:03     INFO - TEST-PASS | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Promise rejected, expecting rejection to match /Invalid tab ID: 0/, got "Invalid tab ID: 0": Create call failed as expected - 
[task 2016-11-12T23:26:03.969871Z] 23:26:03     INFO - Try to create a window with two URLs
[task 2016-11-12T23:26:03.971450Z] 23:26:03     INFO - Buffered messages logged at 23:24:56
[task 2016-11-12T23:26:03.974681Z] 23:26:03     INFO - Console message: [JavaScript Error: "Unknown listener at childId={6c3194eb-ef3f-409c-9b64-71c7c8189c96}.2465-0 path=tabs.onUpdated listenerId=2484-0
[task 2016-11-12T23:26:03.976690Z] 23:26:03     INFO - " {file: "resource://gre/modules/ExtensionChild.jsm" line: 589}]
[task 2016-11-12T23:26:03.978589Z] 23:26:03     INFO - receiveMessage@resource://gre/modules/ExtensionChild.jsm:589:9
[task 2016-11-12T23:26:03.985676Z] 23:26:03     INFO - _callHandlers/<@resource://gre/modules/MessageChannel.jsm:574:17
[task 2016-11-12T23:26:03.987355Z] 23:26:03     INFO - _callHandlers@resource://gre/modules/MessageChannel.jsm:573:14
[task 2016-11-12T23:26:03.988978Z] 23:26:03     INFO - _handleMessage/deferred.promise<@resource://gre/modules/MessageChannel.jsm:637:7
[task 2016-11-12T23:26:03.990388Z] 23:26:03     INFO - _handleMessage@resource://gre/modules/MessageChannel.jsm:634:24
[task 2016-11-12T23:26:03.991864Z] 23:26:03     INFO - receiveMessage@resource://gre/modules/MessageChannel.jsm:165:5
[task 2016-11-12T23:26:03.993642Z] 23:26:03     INFO - 
[task 2016-11-12T23:26:03.995646Z] 23:26:03     INFO - Console message: [JavaScript Error: "Unknown listener at childId={6c3194eb-ef3f-409c-9b64-71c7c8189c96}.2465-0 path=tabs.onUpdated listenerId=2484-0
[task 2016-11-12T23:26:03.997687Z] 23:26:03     INFO - " {file: "resource://gre/modules/ExtensionChild.jsm" line: 589}]
[task 2016-11-12T23:26:04.000782Z] 23:26:04     INFO - receiveMessage@resource://gre/modules/ExtensionChild.jsm:589:9
[task 2016-11-12T23:26:04.005372Z] 23:26:04     INFO - _callHandlers/<@resource://gre/modules/MessageChannel.jsm:574:17
[task 2016-11-12T23:26:04.007344Z] 23:26:04     INFO - _callHandlers@resource://gre/modules/MessageChannel.jsm:573:14
[task 2016-11-12T23:26:04.011448Z] 23:26:04     INFO - _handleMessage/deferred.promise<@resource://gre/modules/MessageChannel.jsm:637:7
[task 2016-11-12T23:26:04.012914Z] 23:26:04     INFO - _handleMessage@resource://gre/modules/MessageChannel.jsm:634:24
[task 2016-11-12T23:26:04.014662Z] 23:26:04     INFO - receiveMessage@resource://gre/modules/MessageChannel.jsm:165:5
[task 2016-11-12T23:26:04.016311Z] 23:26:04     INFO - 
[task 2016-11-12T23:26:04.021312Z] 23:26:04     INFO - Buffered messages logged at 23:24:57
[task 2016-11-12T23:26:04.023435Z] 23:26:04     INFO - Console message: [JavaScript Error: "Unknown listener at childId={6c3194eb-ef3f-409c-9b64-71c7c8189c96}.2465-0 path=tabs.onUpdated listenerId=2484-0
[task 2016-11-12T23:26:04.025220Z] 23:26:04     INFO - " {file: "resource://gre/modules/ExtensionChild.jsm" line: 589}]
[task 2016-11-12T23:26:04.026632Z] 23:26:04     INFO - receiveMessage@resource://gre/modules/ExtensionChild.jsm:589:9
[task 2016-11-12T23:26:04.028082Z] 23:26:04     INFO - _callHandlers/<@resource://gre/modules/MessageChannel.jsm:574:17
[task 2016-11-12T23:26:04.029606Z] 23:26:04     INFO - _callHandlers@resource://gre/modules/MessageChannel.jsm:573:14
[task 2016-11-12T23:26:04.031137Z] 23:26:04     INFO - _handleMessage/deferred.promise<@resource://gre/modules/MessageChannel.jsm:637:7
[task 2016-11-12T23:26:04.032718Z] 23:26:04     INFO - _handleMessage@resource://gre/modules/MessageChannel.jsm:634:24
[task 2016-11-12T23:26:04.034340Z] 23:26:04     INFO - receiveMessage@resource://gre/modules/MessageChannel.jsm:165:5
[task 2016-11-12T23:26:04.037469Z] 23:26:04     INFO - 
[task 2016-11-12T23:26:04.039409Z] 23:26:04     INFO - Console message: [JavaScript Error: "Unknown listener at childId={6c3194eb-ef3f-409c-9b64-71c7c8189c96}.2465-0 path=tabs.onUpdated listenerId=2484-0
[task 2016-11-12T23:26:04.040912Z] 23:26:04     INFO - " {file: "resource://gre/modules/ExtensionChild.jsm" line: 589}]
[task 2016-11-12T23:26:04.042509Z] 23:26:04     INFO - receiveMessage@resource://gre/modules/ExtensionChild.jsm:589:9
[task 2016-11-12T23:26:04.044353Z] 23:26:04     INFO - _callHandlers/<@resource://gre/modules/MessageChannel.jsm:574:17
[task 2016-11-12T23:26:04.046155Z] 23:26:04     INFO - _callHandlers@resource://gre/modules/MessageChannel.jsm:573:14
[task 2016-11-12T23:26:04.048058Z] 23:26:04     INFO - _handleMessage/deferred.promise<@resource://gre/modules/MessageChannel.jsm:637:7
[task 2016-11-12T23:26:04.050023Z] 23:26:04     INFO - _handleMessage@resource://gre/modules/MessageChannel.jsm:634:24
[task 2016-11-12T23:26:04.054868Z] 23:26:04     INFO - receiveMessage@resource://gre/modules/MessageChannel.jsm:165:5
[task 2016-11-12T23:26:04.056329Z] 23:26:04     INFO - 
[task 2016-11-12T23:26:04.057977Z] 23:26:04     INFO - Buffered messages finished
[task 2016-11-12T23:26:04.059821Z] 23:26:04     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Test timed out - 
[task 2016-11-12T23:26:04.061460Z] 23:26:04     INFO - Not taking screenshot here: see the one that was previously logged
[task 2016-11-12T23:26:04.063400Z] 23:26:04     INFO - TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_windows_create_tabId.js | Extension left running at test shutdown - 
[task 2016-11-12T23:26:04.064829Z] 23:26:04     INFO - Stack trace:
[task 2016-11-12T23:26:04.066870Z] 23:26:04     INFO -     chrome://mochikit/content/tests/SimpleTest/ExtensionTestUtils.js:ExtensionTestUtils.loadExtension/<:107
[task 2016-11-12T23:26:04.071047Z] 23:26:04     INFO -     chrome://mochikit/content/browser-test.js:Tester.prototype.nextTest<:439
[task 2016-11-12T23:26:04.072641Z] 23:26:04     INFO -     timeoutFn@chrome://mochikit/content/browser-test.js:819:9
[task 2016-11-12T23:26:04.074226Z] 23:26:04     INFO -     setTimeout handler*SimpleTest_setTimeoutShim@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:625:12
[task 2016-11-12T23:26:04.075977Z] 23:26:04     INFO -     timeoutFn@chrome://mochikit/content/browser-test.js:812:15
[task 2016-11-12T23:26:04.077492Z] 23:26:04     INFO -     setTimeout handler*Tester_execTest@chrome://mochikit/content/browser-test.js:781:9
[task 2016-11-12T23:26:04.078932Z] 23:26:04     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:657:7
[task 2016-11-12T23:26:04.080587Z] 23:26:04     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:744:59
Assignee: nobody → kmaglione+bmo
status-firefox52: --- → affected
Comment on attachment 8812318 [details]
Bug 1317154: Correctly support multiple concurrent listeners for the same event.

https://reviewboard.mozilla.org/r/94110/#review94312

yikes
Attachment #8812318 - Flags: review?(aswan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa98f9492ef7a1e9de2b21cf2d3b164b7a20955f
Bug 1317154: Correctly support multiple concurrent listeners for the same event. r=aswan
Comment on attachment 8812318 [details]
Bug 1317154: Correctly support multiple concurrent listeners for the same event.

Approval Request Comment
[Feature/regressing bug #]: Bug 1305217
[User impact if declined]: This issue will cause breakage for extensions which add multiple concurrent listeners for the same event in the same context. In practice, this is uncommon, but some extensions will be broken.
[Describe test coverage new/current, TreeHerder]: The features affected by this are extensively covered by existing tests. The patch adds new tests for this issue.
[Risks and why]: Low. This is a fairly simple bug fix.
[String/UUID change made/needed]: None.
Attachment #8812318 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/aa98f9492ef7
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8812318 [details]
Bug 1317154: Correctly support multiple concurrent listeners for the same event.

fix new webextensions issue in aurora52
Attachment #8812318 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
needs rebasing for aurora
Flags: needinfo?(kmaglione+bmo)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: