Closed Bug 1317177 Opened 3 years ago Closed 3 years ago

Fix warnings in IPDL unit tests

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

They don't compile with warnings as errors builds. The fixes are simple: a few override annotations are needed, and a couple of unused functions need to be deleted.
The file IPDLUnitTests.template.cpp has a comment "Autogenerated from Python template.  Hands off." at the top, but I'm not sure where the Python template is. Searching for IPDLUnitTestToString in the tree doesn't turn up anything.
Comment on attachment 8810581 [details]
Bug 1317177, part 1 - Add missing override annotations.

https://reviewboard.mozilla.org/r/92860/#review92890
Attachment #8810581 - Flags: review?(wmccloskey) → review+
Comment on attachment 8810582 [details]
Bug 1317177, part 2 - Remove unused functions.

https://reviewboard.mozilla.org/r/92862/#review92892

The "hands off" comment is intended to be copied to the output file. It doesn't apply to the .template.cpp file. It should really be added by genIPDLUnitTests.py.
Attachment #8810582 - Flags: review?(wmccloskey) → review+
Blocks: buildwarning
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b93d7d560a6
part 1 - Add missing override annotations. r=billm
https://hg.mozilla.org/integration/autoland/rev/58fb4b40215d
part 2 - Remove unused functions. r=billm
https://hg.mozilla.org/mozilla-central/rev/3b93d7d560a6
https://hg.mozilla.org/mozilla-central/rev/58fb4b40215d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.