1317177 - Fix warnings in IPDL unit tests

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

They don't compile with warnings as errors builds. The fixes are simple: a few override annotations are needed, and a couple of unused functions need to be deleted.

Comment 1

[Andrew McCreight (out of office until 8/21) [:mccr8]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3114604ce39331ab9277d951da3a8fd39e824402

Comment 2

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1317177, part 1 - Add missing override annotations.

Review commit: https://reviewboard.mozilla.org/r/92860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92860/

Comment 3

[Andrew McCreight (out of office until 8/21) [:mccr8]]

Attachment: Bug 1317177, part 2 - Remove unused functions.

Review commit: https://reviewboard.mozilla.org/r/92862/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92862/

Comment 4

[Andrew McCreight (out of office until 8/21) [:mccr8]]

The file IPDLUnitTests.template.cpp has a comment "Autogenerated from Python template.  Hands off." at the top, but I'm not sure where the Python template is. Searching for IPDLUnitTestToString in the tree doesn't turn up anything.

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810581 [details]
Bug 1317177, part 1 - Add missing override annotations.

https://reviewboard.mozilla.org/r/92860/#review92890

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8810582 [details]
Bug 1317177, part 2 - Remove unused functions.

https://reviewboard.mozilla.org/r/92862/#review92892

The "hands off" comment is intended to be copied to the output file. It doesn't apply to the .template.cpp file. It should really be added by genIPDLUnitTests.py.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b93d7d560a6
part 1 - Add missing override annotations. r=billm
https://hg.mozilla.org/integration/autoland/rev/58fb4b40215d
part 2 - Remove unused functions. r=billm

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b93d7d560a6
https://hg.mozilla.org/mozilla-central/rev/58fb4b40215d