Cannot reflect usercontext identity color immediately at existing tab even if changing identity color

VERIFIED FIXED in Firefox 53

Status

()

Firefox
Preferences
P3
normal
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: magicp, Assigned: baku)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 affected, firefox53 verified)

Details

(Whiteboard: [userContextId][domsecurity-backlog])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
Steps to Reproduce:
1. Start Nightly
2. Open new container tab (e.g. Personal, identity color is blue)
3. Go to about:preferences#containers
4. Change identity color from blue to yellow

Actual Results:
Cannot reflect usercontext identity color immediately at existing tab even if changing identity color.

Actual Results:
Reflect usercontext identity color immediately.
(Reporter)

Comment 1

a year ago
Created attachment 8810256 [details]
Cannot reflect usercontext identity color immediately.png
(Reporter)

Updated

a year ago
Blocks: 1267916
(Reporter)

Updated

a year ago
status-firefox53: --- → affected
I ran into this several times as well. It looks like the colour/indicators are correctly being changed under the awesome bar, but the tab highlights are not immediately being changed. If you move the tab into it's own separate window, the colour does end up changing.

Platforms:

* macOS 10.12.1 -> affected
* Ubuntu 16.04.1 LTS -> affected
* Win 10 x64 -> affected
Blocks: 1191418
Has STR: --- → yes
OS: Unspecified → All
Hardware: Unspecified → All
Whiteboard: [userContextId][domsecurity-backlog]

Updated

a year ago
Priority: -- → P3
(Assignee)

Comment 3

a year ago
Created attachment 8817196 [details] [diff] [review]
color.patch
Assignee: nobody → amarchesini
Attachment #8817196 - Flags: review?(gijskruitbosch+bugs)

Comment 4

a year ago
Comment on attachment 8817196 [details] [diff] [review]
color.patch

Review of attachment 8817196 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Can you file a followup to switch to weak ref observers?
Attachment #8817196 - Flags: review?(gijskruitbosch+bugs) → review+

Comment 5

a year ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ff0d7460eb6
Propagate contextual-identity-updated notification when an ContextualIdentity is modified, r=gijs
(Assignee)

Updated

a year ago
Blocks: 1322387

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2ff0d7460eb6
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Comment 7

a year ago
I have reproduced this bug with Nightly  52.0a1 (2016-11-13) on Windows 8.1 , 64 Bit ! 

Build   ID    20161113030203
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

This bug's fix is Verified with latest Nightly !

Build   ID    20161208075029
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20161207]

Updated

a year ago
Status: RESOLVED → VERIFIED
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.