Closed Bug 1317199 Opened 8 years ago Closed 7 years ago

[geckoview] Move o.m.g.permissions package out of GeckoView

Categories

(GeckoView :: General, defect)

Product:
GeckoView
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 927831

People

(Reporter: nalexander, Unassigned)

References

Details

Right now, there's a tie between GeckoAppShell, geolocation, and org.mozilla.gecko.permissions. There's no reason that a web rendering should be directly managing dynamic Android permissions; this ticket tracks moving o.m.g.permissions to Fennec and abstracting out the GeckoAppShell connection. This would also help us make GeckoView not depend on android.support.v4.
sebastian: am I reading this situation correctly? Would you expect GeckoView to need the permissions abstraction you built? Or would you expect *consumers* of GeckoView (Fennec, but also others) to manage this themselves, perhaps using GeckoView interface hooks to know when to handle permission requests?
Flags: needinfo?(s.kaspari)
Yeah, I think that's correct. I would expect consumers to implement permission requests themselves. Especially because some steps might require to show app specific UI to the user, e.g.: https://developer.android.com/reference/android/app/Activity.html#shouldShowRequestPermissionRationale(java.lang.String)
Flags: needinfo?(s.kaspari)
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Product: Firefox for Android → GeckoView
You need to log in before you can comment on or make changes to this bug.